Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev setup guide #2283

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Update dev setup guide #2283

merged 2 commits into from
Jul 5, 2023

Conversation

kalopilato
Copy link
Contributor

@kalopilato kalopilato commented Jul 5, 2023 •
edited
Loading

While setting up my development environment I hit a couple snags running bin/setup:

  1. a couple of gems couldn't build because I didn't have Xcode Command Line Tools installed

Screenshot 2023-07-05 at 9 20 14 AM

Screenshot 2023-07-05 at 9 20 29 AM

  1. I wasn't running a compatible node version:

Screenshot 2023-07-05 at 9 19 32 AM

This PR:

  • updates the README to include Xcode Command Line Tools in the setup instructions
  • adds an .nvmrc file so that we can use nvm to use a compatible node version. we could probably make the bin/setup script a bit smarter in future but this should do the trick for now

@buildkite-docs-bot
Copy link
Contributor

Preview URL: https://2283--bk-docs-preview.netlify.app

dannymidnight
dannymidnight approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@dannymidnight dannymidnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Thanks for this 👍

@kalopilato kalopilato merged commit 8303478 into main Jul 5, 2023
1 check passed
@kalopilato kalopilato deleted the update-dev-setup-guide branch July 5, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannymidnight dannymidnight dannymidnight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalopilato @buildkite-docs-bot @dannymidnight