Add docs for job-log-path #2296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdothtml
commented
Jul 13, 2023
data/content/agent_attributes.yaml
Outdated
| default_value: "platform's TempDir; e.g. '/tmp'" | ||
| required: false | ||
| desc: | | ||
| The directory of the temporary job log file created by the `enable-job-log-tmpfile` [agent configuration option](/docs/agent/v3/configuration). Introduced in [TBD](https://github.com/buildkite/agent/releases/tag/TBD). |
There was a problem hiding this comment.
I left the release version as TBD as afaict this hasn't yet been released. Just looking for a review on the wording for now
There was a problem hiding this comment.
The wording here looks good though!
|
Thanks for being on top of this @chrisdothtml! @DrJosh9000 @moskyb, can I leave this with you to include in the docs update for the next agent release? |
DrJosh9000
added a commit
that referenced
this pull request
Jul 19, 2023
|
Ooh, I got confused by the GH UI, but looks like there's now a commit on the main branch with this change now. Guess we can close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding docs for the feature added in buildkite/agent#2174