Skip to content
This repository has been archived by the owner on Jul 13, 2021. It is now read-only.

Commit

Permalink
minor changes via scrutinizr
Browse files Browse the repository at this point in the history
  • Loading branch information
basz committed Feb 3, 2015
1 parent 0471a0e commit 40d3f17
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion src/Service/Factory/PhingServiceFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

namespace BsbPhingService\Service\Factory;

use BsbPhingService\Options\PhingOptions;
use BsbPhingService\Options\ServiceOptions;
use BsbPhingService\Service\PhingService;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;
Expand All @@ -16,7 +18,9 @@ class PhingServiceFactory implements FactoryInterface
*/
public function createService(ServiceLocatorInterface $serviceLocator)
{
$options = $serviceLocator->get('BsbPhingService.serviceOptions');
/** @var ServiceOptions $options */
$options = $serviceLocator->get('BsbPhingService.serviceOptions');
/** @var PhingOptions $phingOptions */
$phingOptions = $serviceLocator->get('BsbPhingService.phingOptions');

return new PhingService($options, $phingOptions);
Expand Down
4 changes: 2 additions & 2 deletions src/Service/PhingService.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,15 @@ public function getPhingOptions()
*
* @return Process
*/
public function build($target = "", $options = null, $immediate = true)
public function build($targets = "", $options = null, $immediate = true)
{
$phingOptions = clone $this->phingOptions;

if ($options !== null) {
$phingOptions->setFromArray($options);
}

$process = $this->createProcessInstance($target, $phingOptions);
$process = $this->createProcessInstance($targets, $phingOptions);

if ($immediate) {
$process->run();
Expand Down

0 comments on commit 40d3f17

Please sign in to comment.