Skip to content
This repository has been archived by the owner on Jun 5, 2020. It is now read-only.

Use global binaries, when all else fails #34

Merged
merged 4 commits into from
Nov 10, 2015

Conversation

dominykas
Copy link
Member

Fixes #31 / #33 - globally installed node_modules are not (and should not, apparently) be require-able, and if you can't require it - you can't find it's .bin folder, so I added a fallback to look for an executable in the PATH (using isaac's which).

Also took the liberty to update dependencies and add relevant node versions to .travis.yml - although my personal opinion is that 0.10 and 0.12 should be dropped.

@dominykas dominykas closed this Nov 10, 2015
@dominykas dominykas deleted the use-global-phantomjs branch November 10, 2015 19:26
@dominykas dominykas restored the use-global-phantomjs branch November 10, 2015 19:26
@dominykas dominykas reopened this Nov 10, 2015
dominykas added a commit that referenced this pull request Nov 10, 2015
Use global binaries, when all else fails
@dominykas dominykas merged commit fb6317a into busterjs:master Nov 10, 2015
@dominykas dominykas deleted the use-global-phantomjs branch November 10, 2015 19:26
@dominykas
Copy link
Member Author

Buster update progress: busterjs/buster#463

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant