Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/json #6

Merged
merged 5 commits into from
Oct 19, 2023
Merged

feature/json #6

merged 5 commits into from
Oct 19, 2023

Conversation

busticated
Copy link
Owner

@busticated busticated commented Oct 19, 2023 •
edited
Loading

Description

Adds json feature to the node-js-release-info crate to facilitate serializing + deserializing from / to json via serde

How to Test

  1. Clone and setup this branch locally (docs)
  2. Review docs: cargo xtask doc --open
  3. Run tests: cargo xtask test
  4. Try out the examples

Outcome

Tests should pass, docs and examples should be clear and helpful, and you should be able to successfully replicate and run the example.

Related / Discussions

#1

Completeness

  • PR opened 🎉
  • Testing instructions have been provided
  • Development How-To's have been provided
  • Docs have been updated (cargo xtask doc)
  • Branch is rebased against target (typically main)

@busticated
Copy link
Owner Author

🥇 🛠️ :shipit:

@busticated busticated merged commit 2bcb4ae into main Oct 19, 2023
6 checks passed
@busticated busticated deleted the feature/json branch October 19, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@busticated