Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Linter - Data Quality #19

Open
7 tasks
bvobart opened this issue Jun 21, 2021 · 0 comments
Open
7 tasks

New Linter - Data Quality #19

bvobart opened this issue Jun 21, 2021 · 0 comments
Assignees

Comments

@bvobart
Copy link
Owner

bvobart commented Jun 21, 2021

The goal for this issue is to build a linter for the Data Quality category to check whether and how a project is using tools to assert quality standards on its input data, e.g. GreatExpectations, TFDV and (maybe) Bulwark, the successor of Engarde.

Firstly, we should figure out, primarily for GreatExpectations and TFDV:

  1. How to apply these tools to a ML project? What generally needs to change about a project in order to implement such a tool? How much effort does this take? The latest branch of the basic project in mllint-example-projects repo can be used as a base for this.
  2. What constitutes effective use of these tools? What kind of checks should / would ML engineers want to implement on their data? Are there any default checks that should always be enabled, or should the user create a certain set of their own checks somehow?
  3. How could mllint measure and assess whether a project is making effective use of these tools?
  4. How could mllint measure and assess whether the checks made by these tools passed? This could entail running GreatExpectations or TFDV in a similar way to what we do for Code Quality linters (Pylint, Mypy, etc.) and parsing the output (bonus points if this output can be formatted in a machine-readable way such as JSON or YAML).

Then, to implement it:

  • Figure out the answers to the above questions.
  • Determine which linting rules mllint will use to check whether a project is using GreatExpectations correctly
  • Determine which linting rules mllint will use to check whether a project is using TFDV correctly
  • Implement the linter to check these rules (just copy the template linter and start editing that)
  • Implement tests for the linter
  • Write the documentation to go with those rules
  • Write the documentation for the category
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants