Fix F811 flake8 errors

bxlab · Dec 7, 2023 · 0a1faaa · 0a1faaa
1 parent ccd8c6b
commit 0a1faaa
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/lib/bx/cookbook/attribute.py b/lib/bx/cookbook/attribute.py
@@ -113,7 +113,6 @@ def _attribute(permission="rwd", **kwds):
 
     def _property(attrname, default):
         propname, attrname = attrname, mangle(classname, attrname)
-        fget, fset, fdel, doc = None, None, None, propname
         if "r" in permission:
 
             def fget(self):
@@ -124,11 +123,17 @@ def fget(self):
                     setattr(self, attrname, default)
                 return value
 
+        else:
+            fget = None
+
         if "w" in permission:
 
             def fset(self, value):
                 setattr(self, attrname, value)
 
+        else:
+            fset = None
+
         if "d" in permission:
 
             def fdel(self):
@@ -139,7 +144,9 @@ def fdel(self):
                 # calling fget can restore this attribute, so remove property
                 delattr(self.__class__, propname)
 
-        return property(fget=fget, fset=fset, fdel=fdel, doc=doc)
+        else:
+            fdel = None
+        return property(fget=fget, fset=fset, fdel=fdel, doc=propname)
 
     for attrname, default in kwds.items():
         classdict[attrname] = _property(attrname, default)