Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix clang warnings #29

Open
yurivict opened this issue Feb 9, 2018 · 0 comments
Open

Please fix clang warnings #29

yurivict opened this issue Feb 9, 2018 · 0 comments

Comments

@yurivict
Copy link

yurivict commented Feb 9, 2018

Getting these with clang-40:

src/samtools/bgzf.c:247:17: warning: implicit conversion from 'const int' to 'bgzf_byte_t' (aka 'signed char') changes value from 139 to -117 [-Wconstant-conversion]
    buffer[1] = GZIP_ID2;
              ~ ^~~~~~~~
src/samtools/bgzf.c:255:17: warning: implicit conversion from 'const int' to 'bgzf_byte_t' (aka 'signed char') changes value from 255 to -1 [-Wconstant-conversion]
    buffer[9] = OS_UNKNOWN;
              ~ ^~~~~~~~~~
src/pwm_utils.c:11:27: warning: implicitly declaring library function 'strlen' with type 'unsigned long (const char *)' [-Wimplicit-function-declaration]
        int string_size = strlen(argv[1]);
                          ^
lib/bx/bbi/bbi_file.c:8257:32: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
  __pyx_t_11 = ((__pyx_v_start < 0) != 0);
                 ~~~~~~~~~~~~~ ^ ~
src/bunzip/micro-bunzip.c:629:12: warning: assigning to 'unsigned char *' from 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
                bd->inbuf=inbuf;
                         ^~~~~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant