Have provider invoke
fn support not being given a function name
#776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds support to QuickJS provider's exported
invoke
function to handle not being given a function name. This shouldn't change any behaviour.Why am I making this change?
As part of #768, we'll want to remove the
eval_bytecode
exported function (to make it easier for plugin developers) and just haveinvoke
soinvoke
needs to also be able to handleeval_bytecode
's use case where there is not an exported function to run.I haven't deleted
eval_bytecode
in this PR because we still emit function invocations for it. I also haven't updated the dynamically linked codegen code to callinvoke
instead ofeval_bytecode
because all runtime environments using the provider would need to be updated with a provider version that includes this code change, otherwise new modules generated to useinvoke
with0
arguments for function name pointer and length would fail.Checklist
javy-cli
andjavy-core
do not require updating CHANGELOG files.