Remove cargo-wasi and update WASI target #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcharles
force-pushed
the
jc.remove-cargo-wasi-and-switch-target
branch
from
5be6fc6
to
d712f47
Compare
saulecabrera
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Removes cargo-wasi and updates any uses the
wasm32-wasitarget towasm32-wasip1.Also updates one of the test macros because, without using cargo-wasi, the tests execute in the crate directory and not the workspace root.
Why am I making this change?
Closes #586 and closes #779. Rust is removing support for the
wasm32-wasitarget so we need to update references to use the new target.Checklist
javy-cliandjavy-coredo not require updating CHANGELOG files.