Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cargo-wasi and update WASI target #782

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Removes cargo-wasi and updates any uses the wasm32-wasi target to wasm32-wasip1.

Also updates one of the test macros because, without using cargo-wasi, the tests execute in the crate directory and not the workspace root.

Why am I making this change?

Closes #586 and closes #779. Rust is removing support for the wasm32-wasi target so we need to update references to use the new target.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@jeffcharles jeffcharles force-pushed the jc.remove-cargo-wasi-and-switch-target branch from 5be6fc6 to d712f47 Compare October 16, 2024 22:02
@jeffcharles jeffcharles marked this pull request as ready for review October 16, 2024 22:18
crates/test-macros/src/lib.rs Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
crates/test-macros/src/lib.rs Outdated Show resolved Hide resolved
@jeffcharles jeffcharles merged commit 6eef581 into main Oct 18, 2024
7 checks passed
@jeffcharles jeffcharles deleted the jc.remove-cargo-wasi-and-switch-target branch October 18, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change wasm32-wasi targets to wasm32-wasip1 Stop using cargo-wasi
2 participants