Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The dynamic code generator has been augmented to handle static code generation and the original static code generator has been deleted. The
bin
build forjavy-core
has also been deleted since it's no longer necessary. I've also changed the way we send the runtime configuration into the provider to use stdin instead of an environment variable.I've divided the PR into two commits, one moves the generator into
mod.rs
without changes, and the second commit makes the actual changes. I would suggest looking at the second commit to see the changes to the generator.Why am I making this change?
Part of #768. To simplify plugin development, we only want plugin developers to have to build a Wasm cdylib as opposed to a cdylib and a binary Wasm module. Unifying the code generators into one code generator means we only need the cdylib now.
The change to how we propagate the runtime configuration into the provider is because I noticed that the value I was setting for the
JS_RUNTIME_CONFIG
environment variable was unexpectedly persisting across invocations ofinitialize_runtime
. Using stdin appears to avoid the issue.Checklist
javy-cli
andjavy-core
do not require updating CHANGELOG files.