Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 16 #23

Merged
merged 6 commits into from
Jan 23, 2023
Merged

node 16 #23

merged 6 commits into from
Jan 23, 2023

Conversation

joshgubler
Copy link
Member

No description provided.

@joshgubler
Copy link
Member Author

fixes #22

Copy link

@stuft2 stuft2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we don't just skip to Node 18?

@joshgubler joshgubler closed this Jan 23, 2023
@joshgubler joshgubler reopened this Jan 23, 2023
package.json Outdated Show resolved Hide resolved
@joshgubler joshgubler changed the title node 16 node 18 Jan 23, 2023
@joshgubler joshgubler requested a review from a team January 23, 2023 21:47
@joshgubler
Copy link
Member Author

This will be v1.1.2

action.yml Outdated Show resolved Hide resolved
@joshgubler joshgubler changed the title node 18 node 16 Jan 23, 2023
@GaryGSC
Copy link
Member

GaryGSC commented Jan 23, 2023

Thanks for fixing that. ♥

Can we call this v2? The change from node12 to node16 is breaking for anyone using a self-hosted runner with a version that's so old that it doesn't support using: 'node16'. I realize that criteria doesn't apply to BYU, but based on the handful of stars on this repo, I believe we have some external users.

@joshgubler
Copy link
Member Author

Sure. Unfortunately that will be more work to get the security fixes to the end of the row. But that's life.

@GaryGSC
Copy link
Member

GaryGSC commented Jan 23, 2023

Yeah. Sometimes it's hard to be good citizens. 🙁

The process would be to:

  • Change the base of this PR to target master and update the README's example to reference @v2
  • Merge this PR
  • Cut a new v2.0.0 release from the tip of master
  • Make a new branch, v2, that matches master so that people can reference @v2 and pick up minor/patch updates in the future

@GaryGSC
Copy link
Member

GaryGSC commented Jan 23, 2023

(I tend to prefer branches to support the common @v2 use case rather than floating tags.)

@GaryGSC

This comment was marked as outdated.

@joshgubler joshgubler changed the base branch from v1 to master January 23, 2023 22:28
@joshgubler joshgubler merged commit 9e46bf5 into master Jan 23, 2023
@joshgubler joshgubler deleted the node16 branch January 23, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants