-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMT-style push/pop assertion levels #17
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorry, I think this belongs in an outer layer (a SMT solver, typically). I personally think push/pop is a bad interface anyway and |
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
push
andpop
methods to theSolverInterface
, similar in style to the SMT-LIB(push)
and(pop n)
.push
works by creating a fresh literal, and adding it as an assumption to each callsolve_limited_th
until the nextpop
. These literals are also implicitly added to each clause that is added until the nextpop
. This is fairly similar to how they could be manually implemented on top of aSolverInterface
but has a few optimization from being implemented internally.solver.v.assumptions
can be reused to store literals corresponding to assertion levels instead of requiring a separate buffer.solver.v.ok
is now au32
(0
corresponds to what would have been false, and anything else corresponds to what would have been true) which remembers what assertion levels are already known to be contradictory to avoid extra work.