Fix KEDA ScaledObject KeyError

Safely check if the key exists before accessing it
caas-team · Aug 22, 2024 · 9f4913d · 9f4913d
1 parent 2533c9b
commit 9f4913d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/kube_downscaler/scaler.py b/kube_downscaler/scaler.py
@@ -660,9 +660,10 @@ def scale_down(
             f"Scaling down {resource.kind} {resource.namespace}/{resource.name} from {replicas} to {target_replicas} replicas (uptime: {uptime}, downtime: {downtime})"
         )
     elif resource.kind == "ScaledObject":
-        if resource.annotations[ScaledObject.keda_pause_annotation] is not None:
-            paused_replicas = resource.annotations[ScaledObject.keda_pause_annotation]
-            resource.annotations[ScaledObject.last_keda_pause_annotation_if_present] = paused_replicas
+        if ScaledObject.keda_pause_annotation in resource.annotations:
+            if resource.annotations[ScaledObject.keda_pause_annotation] is not None:
+                paused_replicas = resource.annotations[ScaledObject.keda_pause_annotation]
+                resource.annotations[ScaledObject.last_keda_pause_annotation_if_present] = paused_replicas
         resource.annotations[ScaledObject.keda_pause_annotation] = "0"
         logger.info(
             f"Pausing {resource.kind} {resource.namespace}/{resource.name} (uptime: {uptime}, downtime: {downtime})"