Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier, Eslint and Husky #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

lipis
Copy link
Contributor

@lipis lipis commented Dec 26, 2017

This PR is fixing the #99 and it's splitted into two commits.. one for the settings and the one that formats the files.

Except .js files, this PR is also fixes the .json and .md files.


Some of the rules that could be added eventually.. :)

  id-length: 2
  no-magic-numbers: [2, {ignore: [-1, 0, 1]}]
  no-shadow: 2
  sort-keys: [2, asc, {caseSensitive: true, natural: true}]

Based on prettier-setup

@lipis
Copy link
Contributor Author

lipis commented Dec 26, 2017

Feel free to go through the .eslintrc.yaml and .prettierrc.yaml if you want add/remove/change anything...

@caiogondim
Copy link
Owner

That's a massive PR 😄

The only thing holding me from merging this PR is the use of ES6+ syntax, like const, let, arrow functions, ...
We have to keep compatibility with older browsers.

Other than that, let's do it 💪

@lipis
Copy link
Contributor Author

lipis commented Jan 25, 2018

I forgot about this one.. will come back to it over the weekend!

@caiogondim
Copy link
Owner

No worries. Let me know if you need some help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants