Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bash script failing to parse space-separated or single-letter argument values #34

Closed
wants to merge 1 commit into from
Closed

Fixes bash script failing to parse space-separated or single-letter argument values #34

wants to merge 1 commit into from

Conversation

jnm2
Copy link
Contributor

@jnm2 jnm2 commented Aug 25, 2017 •
edited
Loading

Fixes #33 (might be a good idea not to take my word for it 😈)

We need to add tests for this, but I put this up for early review so that we can possibly publish the fix to everyone sooner than that.

@jnm2 jnm2 mentioned this pull request Aug 25, 2017
Open
@gep13
Copy link
Member

gep13 commented Aug 25, 2017

@agc93 can you take this change for a spin and verify everything is good? Thanks.

@jnm2 jnm2 mentioned this pull request Sep 8, 2017
Merged
@cake-build cake-build deleted a comment from dnfclas Dec 11, 2017
@jnm2
Copy link
Contributor Author

jnm2 commented Feb 16, 2018

Closing in favor of #53.

@jnm2 jnm2 closed this Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixing build.sh and argument parsing consistency
4 participants
@jnm2 @gep13 @dnfadmin @dnfclas