Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make axios a provider #25

Open
cakekindel opened this issue Aug 26, 2019 · 2 comments
Open

refactor: make axios a provider #25

cakekindel opened this issue Aug 26, 2019 · 2 comments
Labels
scope:api Changes to the API layer tag:good first issue type:refactor Change that doesn't introduce a feature or fix a bug

Comments

@cakekindel
Copy link
Owner

No description provided.

@cakekindel cakekindel added scope:api Changes to the API layer tag:good first issue type:refactor Change that doesn't introduce a feature or fix a bug labels Aug 26, 2019
@cakekindel cakekindel added this to the Feature Complete milestone Aug 26, 2019
@cakekindel cakekindel removed this from the Egg Party MVP milestone Oct 11, 2019
@marc-hamilton-at-work
Copy link
Collaborator

Not sure what we're looking to accomplish with this

@cakekindel
Copy link
Owner Author

the issue is since axios is a "static" module i.e. we use it directly by importing rather than via DI, it's kinda hard to unit test. The solution could be similar to db-connection.provider.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope:api Changes to the API layer tag:good first issue type:refactor Change that doesn't introduce a feature or fix a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marc-hamilton-at-work @cakekindel