Cache apt packages #7978
Cache apt packages #7978
Conversation
|
currently that step takes 3 minutes per variant in CI. |
.github/workflows/ci.yml
Outdated
| - uses: awalsh128/cache-apt-pkgs-action@v1 | ||
| with: | ||
| packages: texlive-latex-recommended texlive-latex-extra texlive-fonts-recommended texlive-lang-all | ||
| version: 1.0 |
There was a problem hiding this comment.
Do we need execute_install_scripts: true ?
There was a problem hiding this comment.
The install seemed to worked fine without it hence I didn't add it. These packages probably don't have any post install scripts.
.github/workflows/ci.yml
Outdated
| - uses: awalsh128/cache-apt-pkgs-action@v1 | ||
| with: | ||
| packages: texlive-latex-recommended texlive-latex-extra texlive-fonts-recommended texlive-lang-all | ||
| version: 1.0 |
There was a problem hiding this comment.
Should the version be ubuntu-24.04 instead of 1.0?
There was a problem hiding this comment.
This is a user defined value. Can be anything you want, so I just used what's shown in their docs.
There was a problem hiding this comment.
I'm saying it's tied to this CI, right, so we want it to change on version change? I doubt we're updating ubuntu any time soon - not sure what happens when it needs to install newer versions.
There was a problem hiding this comment.
I have updated the cache version to match the OS
.github/workflows/ci.yml
Outdated
| - uses: awalsh128/cache-apt-pkgs-action@v1 | ||
| with: | ||
| packages: texlive-latex-recommended texlive-latex-extra texlive-fonts-recommended texlive-lang-all | ||
| version: 1.0 |
There was a problem hiding this comment.
The install seemed to worked fine without it hence I didn't add it. These packages probably don't have any post install scripts.
.github/workflows/ci.yml
Outdated
| - uses: awalsh128/cache-apt-pkgs-action@v1 | ||
| with: | ||
| packages: texlive-latex-recommended texlive-latex-extra texlive-fonts-recommended texlive-lang-all | ||
| version: 1.0 |
There was a problem hiding this comment.
This is a user defined value. Can be anything you want, so I just used what's shown in their docs.
That way it's easier to remember updating the key when the OS version is changed.
looking at that last commit it doesn't seem like it... |
In the last commit the cache version was changed so it would recreate the cache. |
|
I triggered a re-run to test. |
The cache step only took 12s, @LordSimal can rest easy now 😄. |
|
Just making sure that this change actually works. Otherwise it would just be an external dependency in the built step which could break in the future 😉 |
No description provided.