Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(enrollment): funding source from card token #14

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Feat(enrollment): funding source from card token #14

merged 4 commits into from
Feb 6, 2024

Conversation

angela-tran
Copy link
Member

Part of #10

This PR adds a method to Client to take in a card token provided from hosted verification and get the corresponding funding source.

@angela-tran angela-tran self-assigned this Jan 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  littlepay/api
  client.py
  funding_sources.py
Project Total  

This report was generated by python-coverage-comment-action

@angela-tran angela-tran changed the title Feat: funding source from card token Feat(enrollment): funding source from card token Jan 18, 2024
@angela-tran
Copy link
Member Author

Need to rebase this

@angela-tran angela-tran marked this pull request as ready for review January 26, 2024 23:33
@angela-tran angela-tran requested a review from a team as a code owner January 26, 2024 23:33
@thekaveman thekaveman mentioned this pull request Jan 30, 2024
Closed
3 tasks
thekaveman
thekaveman requested changes Feb 5, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Couple of small suggestions.

littlepay/api/funding_sources.py Show resolved Hide resolved
tests/api/test_funding_sources.py Show resolved Hide resolved
@thekaveman thekaveman added the api New API feature implementation or refactor label Feb 5, 2024
thekaveman
thekaveman approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@angela-tran angela-tran merged commit 9a1e4c1 into main Feb 6, 2024
3 checks passed
@angela-tran angela-tran deleted the feat/funding-source-from-token branch February 6, 2024 16:36
@thekaveman thekaveman mentioned this pull request Feb 6, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@angela-tran angela-tran

Labels
api New API feature implementation or refactor
Projects
None yet
Milestone
Back Office API Enrollment
Development

Successfully merging this pull request may close these issues.
2 participants
@angela-tran @thekaveman