-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: update funding source expiry from concession group #36
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
76fb5dd
to
25ff58a
Compare
for a funding source already linked to a concession group
PUT returns a ListResponse, but with only a single item, so pull it out and return that instead to simplify caller consumption
a152886
to
5655864
Compare
Question @angela-tran: Do you think it makes sense to create a {
"id": "9002b586-9c53-43c6-b274-5615adb856ee",
"participant_id": "test_participant",
"concession_expiry": "2024-07-03T00:00:00Z",
"concession_created_at": "2024-07-03T00:00:00Z",
"concession_updated_at": "2024-07-03T00:00:00Z"
} We could do some parsing of the Thoughts? |
I think as a consumer, I would want to have the |
parses optional datetime values when provided
Thanks @angela-tran, PR is updated with a new Seeing a test failure in Python 3.10 related to parsing a Yep, it seems like before Python 3.11,
It felt easier to update the code than worry about changing compatibility with Python versions. Although |
0f76038
to
ca8a0fc
Compare
support Python 3.10+ by fixing datetime parsing from known ISO 8601 format with 'Z' offset character for UTC see https://docs.python.org/3.11/library/datetime.html#datetime.datetime.fromisoformat
ca8a0fc
to
7bc81b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 👍
Closes #29
Implements a generic
PUT
handler in the client, returning aListResponse
per the known API specs.Implements
update_concession_group_funding_source_expiry
method to update the expiration of an existing funding source in a concession group. Parses theListResponse
and returns the first.list
item. This should be the only list item according to the known API specs.