CodyGarciaa/Legal-Rights-Prea-Pages #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
philipye314
reviewed
Oct 17, 2024
philipye314
reviewed
Oct 17, 2024
philipye314
reviewed
Oct 17, 2024
philipye314
reviewed
Oct 17, 2024
philipye314
reviewed
Oct 17, 2024
philipye314
pushed a commit
that referenced
this pull request
Oct 25, 2024
* set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol
philipye314
added a commit
that referenced
this pull request
Oct 25, 2024
* navigation * got rid of unused files * CodyGarciaa/Legal-Rights-Prea-Pages (#13) * set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <philipye314@gmail.com> * [bug fix] removed extra type file * navigation * got rid of unused files * [fix] 🐐🐐🐐 * [fix] did screen props * deleted unused files --------- Co-authored-by: philipye314 <philipye314@gmail.com> Co-authored-by: CodyGarciaa <112846683+CodyGarciaa@users.noreply.github.com> Co-authored-by: angelinetu <157329739+angelinetu@users.noreply.github.com> Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> Co-authored-by: Arfa Momin <113748174+arfamomin@users.noreply.github.com>
CodyGarciaa
added a commit
that referenced
this pull request
Oct 26, 2024
* navigation * got rid of unused files * CodyGarciaa/Legal-Rights-Prea-Pages (#13) * set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <philipye314@gmail.com> * [bug fix] removed extra type file * navigation * got rid of unused files * [fix] 🐐🐐🐐 * [fix] did screen props * deleted unused files --------- Co-authored-by: philipye314 <philipye314@gmail.com> Co-authored-by: CodyGarciaa <112846683+CodyGarciaa@users.noreply.github.com> Co-authored-by: angelinetu <157329739+angelinetu@users.noreply.github.com> Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> Co-authored-by: Arfa Momin <113748174+arfamomin@users.noreply.github.com>
CodyGarciaa
added a commit
that referenced
this pull request
Oct 26, 2024
* navigation * got rid of unused files * CodyGarciaa/Legal-Rights-Prea-Pages (#13) * set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <philipye314@gmail.com> * [bug fix] removed extra type file * navigation * got rid of unused files * [fix] 🐐🐐🐐 * [fix] did screen props * deleted unused files --------- Co-authored-by: philipye314 <philipye314@gmail.com> Co-authored-by: CodyGarciaa <112846683+CodyGarciaa@users.noreply.github.com> Co-authored-by: angelinetu <157329739+angelinetu@users.noreply.github.com> Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> Co-authored-by: Arfa Momin <113748174+arfamomin@users.noreply.github.com>
philipye314
added a commit
that referenced
this pull request
Nov 1, 2024
* navigation * got rid of unused files * CodyGarciaa/Legal-Rights-Prea-Pages (#13) * set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <philipye314@gmail.com> * [bug fix] removed extra type file * navigation * got rid of unused files * [fix] 🐐🐐🐐 * [fix] did screen props * deleted unused files --------- Co-authored-by: philipye314 <philipye314@gmail.com> Co-authored-by: CodyGarciaa <112846683+CodyGarciaa@users.noreply.github.com> Co-authored-by: angelinetu <157329739+angelinetu@users.noreply.github.com> Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> Co-authored-by: Arfa Momin <113748174+arfamomin@users.noreply.github.com>
philipye314
added a commit
that referenced
this pull request
Nov 1, 2024
* navigation * got rid of unused files * CodyGarciaa/Legal-Rights-Prea-Pages (#13) * set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <philipye314@gmail.com> * [bug fix] removed extra type file * navigation * got rid of unused files * [fix] 🐐🐐🐐 * [fix] did screen props * deleted unused files --------- Co-authored-by: philipye314 <philipye314@gmail.com> Co-authored-by: CodyGarciaa <112846683+CodyGarciaa@users.noreply.github.com> Co-authored-by: angelinetu <157329739+angelinetu@users.noreply.github.com> Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> Co-authored-by: Arfa Momin <113748174+arfamomin@users.noreply.github.com>
philipye314
added a commit
that referenced
this pull request
Nov 1, 2024
* changed page setup to render supabase data * display is now sorted based on page number * passing in full data for each language to video page * new videos kinda working, just not playing rip; having problems with useState not being instant * lowk finished, but useState making solution a bit scuffed... video's not playing anymore. but all the interactivity with supabase and within the app works lol * not much, only rerendered on index now, comments for better understanding, video still not playing rip * finished sprint, video plays bc of useref instead of usestate * fixed very minor bug where the first page wont display * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <philipye314@gmail.com> * [bug fix] removed extra type file * Charlottelaw/jdi 14 tab navigation (#12) * navigation * got rid of unused files * CodyGarciaa/Legal-Rights-Prea-Pages (#13) * set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <philipye314@gmail.com> * [bug fix] removed extra type file * navigation * got rid of unused files * [fix] 🐐🐐🐐 * [fix] did screen props * deleted unused files --------- Co-authored-by: philipye314 <philipye314@gmail.com> Co-authored-by: CodyGarciaa <112846683+CodyGarciaa@users.noreply.github.com> Co-authored-by: angelinetu <157329739+angelinetu@users.noreply.github.com> Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> Co-authored-by: Arfa Momin <113748174+arfamomin@users.noreply.github.com> * fixed some style, tried video player a bit * Charlottelaw/jdi 14 tab navigation (#12) * navigation * got rid of unused files * CodyGarciaa/Legal-Rights-Prea-Pages (#13) * set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <philipye314@gmail.com> * [bug fix] removed extra type file * navigation * got rid of unused files * [fix] 🐐🐐🐐 * [fix] did screen props * deleted unused files --------- Co-authored-by: philipye314 <philipye314@gmail.com> Co-authored-by: CodyGarciaa <112846683+CodyGarciaa@users.noreply.github.com> Co-authored-by: angelinetu <157329739+angelinetu@users.noreply.github.com> Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> Co-authored-by: Arfa Momin <113748174+arfamomin@users.noreply.github.com> * changed page setup to render supabase data * passing in full data for each language to video page * fixed type errors * deleted unnecessary files * fixed philip's comments besides english/spanishModule's defualt usestate * fixed some pretty warnings * done seekHelp midfi (#21) * done seekHelp midfi * moved caret + made button collapsable * styling changes * minor styling changes * minor == fix --------- Co-authored-by: philipye314 <philipye314@gmail.com> * changed page setup to render supabase data * display is now sorted based on page number * passing in full data for each language to video page * new videos kinda working, just not playing rip; having problems with useState not being instant * lowk finished, but useState making solution a bit scuffed... video's not playing anymore. but all the interactivity with supabase and within the app works lol * not much, only rerendered on index now, comments for better understanding, video still not playing rip * finished sprint, video plays bc of useref instead of usestate * fixed very minor bug where the first page wont display * Charlottelaw/jdi 14 tab navigation (#12) * navigation * got rid of unused files * CodyGarciaa/Legal-Rights-Prea-Pages (#13) * set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <philipye314@gmail.com> * [bug fix] removed extra type file * navigation * got rid of unused files * [fix] 🐐🐐🐐 * [fix] did screen props * deleted unused files --------- Co-authored-by: philipye314 <philipye314@gmail.com> Co-authored-by: CodyGarciaa <112846683+CodyGarciaa@users.noreply.github.com> Co-authored-by: angelinetu <157329739+angelinetu@users.noreply.github.com> Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> Co-authored-by: Arfa Momin <113748174+arfamomin@users.noreply.github.com> * fixed some style, tried video player a bit * Charlottelaw/jdi 14 tab navigation (#12) * navigation * got rid of unused files * CodyGarciaa/Legal-Rights-Prea-Pages (#13) * set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <philipye314@gmail.com> * [bug fix] removed extra type file * navigation * got rid of unused files * [fix] 🐐🐐🐐 * [fix] did screen props * deleted unused files --------- Co-authored-by: philipye314 <philipye314@gmail.com> Co-authored-by: CodyGarciaa <112846683+CodyGarciaa@users.noreply.github.com> Co-authored-by: angelinetu <157329739+angelinetu@users.noreply.github.com> Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> Co-authored-by: Arfa Momin <113748174+arfamomin@users.noreply.github.com> * changed page setup to render supabase data * passing in full data for each language to video page * fixed type errors * deleted unnecessary files * fixed philip's comments besides english/spanishModule's defualt usestate * fixed some pretty warnings * deleted useless file --------- Co-authored-by: angelinetu <157329739+angelinetu@users.noreply.github.com> Co-authored-by: Philip Ye <97428041+philipye314@users.noreply.github.com> Co-authored-by: philipye314 <philipye@berkeley.edu> Co-authored-by: Arfa Momin <113748174+arfamomin@users.noreply.github.com> Co-authored-by: philipye314 <philipye314@gmail.com> Co-authored-by: Charlotte Law <69742430+CharlotteLaw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Screenshots
How to review
Next steps
Relevant links
Online sources
Related PRs
CC: @philipye314