Google client_id missing

[ropic]

Issue Summary

On setup Connect your calendar, a request is made to api/integrations/googlecalendar/add?state=...

Response: {"message":"Google client_id missing."}

Technical details

version: 1.6.2
I have on .env.appStore,
GOOGLE_API_CREDENTIALS='{"web":{"client...
GOOGLE_LOGIN_ENABLED=true

[milospuac]

Hi there. Thanks for reaching out. Our team will investigate this

[nosovk]

cal.com/packages/prisma/seed-app-store.ts

Lines 133 to 145 in 1be5510

	const { client_secret, client_id, redirect_uris } = JSON.parse(process.env.GOOGLE_API_CREDENTIALS).web;
	await createApp("google-calendar", "googlecalendar", ["calendar"], "google_calendar", {
	client_id,
	client_secret,
	redirect_uris,
	});
	await createApp("google-meet", "googlevideo", ["video"], "google_video", {
	client_id,
	client_secret,
	redirect_uris,
	});
	} catch (e) {
	if (e instanceof Error) console.error("Error adding google credentials to DB:", e.message);

actually looks like if env var was added after db initialization then value will be ignored

[nosovk]

Manually adding to db works. It's not reflected in docs, but possible

[zomars]

there's a command to reseed the App Store, in packages/prisma you can run yarn seed-app-store

[yodahuang]

I see the same error with newly created instance. While the json is being put in to envvar, it seems that the client is not reading it successfully.

[nosovk]

It seems that format of key is different, current one looks like:

{"web":{"client_id":"xxx.apps.googleusercontent.com","project_id":"app-id","auth_uri":"https://accounts.google.com/o/oauth2/auth","token_uri":"https://oauth2.googleapis.com/token","auth_provider_x509_cert_url":"https://www.googleapis.com/oauth2/v1/certs","client_secret":"GOCSPX-xxxx","redirect_uris":["https://cal.com/api/integrations/googlecalendar/callback"],"javascript_origins":["https://cal.com"]}}

probably removing web wrapper could help

[nosovk]

nope, it didnt help :(

[hariombalhara]

This should be fixed in latest main. Please check.

[timchambers]

Came here to mention that I may be hitting a similar issue—I'm attempting an upgrade from v1.4.1 to v1.8.5, and the "Sign in with Google" button is no longer available on the login screen (http://localhost:3000/auth/login). This is happening with the main branch today, too.

After updating my local checkout to the current main, I ran through these upgrade steps:

yarn workspace @calcom/prisma db-deploy

yarn predev

I've migrated my GOOGLE_ vars to .env.appStore file…

GOOGLE_API_CREDENTIALS='{"web":{"client_id":"REDACTED.apps.googleusercontent.com","project_id":"REDACTED","auth_uri":"https://accounts.google.com/o/oauth2/auth","token_uri":"https://oauth2.googleapis.com/token","auth_provider_x509_cert_url":"https://www.googleapis.com/oauth2/v1/certs","client_secret":"REDACTED","redirect_uris":["https://REDACTED/api/auth/callback/google","http://localhost:3000/api/auth/callback/google","https://REDACTED/api/integrations/googlecalendar/callback"]}}'
GOOGLE_LOGIN_ENABLED='true'

cd packages/prisma                     
yarn seed-app-store

And yet, after running yarn dev to start up a local instance, the Sign in with Google button is not shown. I even updated the keys value in the App table for the google-calendar and google-meet clients. Is there another place in the database I should update for Sign in with Google?

[zomars]

Sorry I've misread, can you try putting GOOGLE_LOGIN_ENABLED=true in you env variables?

[timchambers]

@zomars Yes, I've tried all the variations of that, too, just in case there was some weird quote/string issue at play. No luck with any of that. The syntax I quoted above (single quotes) is the one I'm currently using for both GOOGLE_LOGIN_ENABLED and GOOGLE_API_CREDENTIALS

GOOGLE_LOGIN_ENABLED='true'

GOOGLE_LOGIN_ENABLED=true

GOOGLE_LOGIN_ENABLED="true"

[timchambers]

Ooh, @zomars when I move both of those GOOGLE_ variables from .env.appStore back to .env, I see the button again. Perhaps the .env.appStore file isn't being included properly?

[zomars]

The .env.appStore is used for seeding the App Store database, will look into clarifying that.

[timchambers]

@zomars Thanks, clarification on needing to seed the App Store after a version upgrade would be helpful, too, if that's necessary. The way the .env.example and .env.appStore.example files are now written makes it look like the GOOGLE_ etc. variables belong only in .env.appStore, which is why I moved them there after updating to v1.8.5