-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Simple markdown template #107
Comments
@lfgcampos Thanks for logging this. This isn't something I've personally encountered, but I can see how some changes would improve things. We could add a simple markdown template as you've suggested, but I think I'd prefer to limit the output of the existing templates so that up to Perhaps the output could be along the lines of:
What do you think @lfgcampos? Would that cover your use case? Would you be in a position to help action this change? |
Thanks for the quick reply @benschwarz! Another small thing I would add would be the number of optimized images in case the table is not shown. Sure, I can try to work on this change as it looks trivial! |
PR is opened! |
Hi @benschwarz, sorry to bother you but any chance to look at the PR? |
What problem would this feature solve?
Currently, the only output we can get from the action is the
steps.calibre.outputs.markdown
which uses either thepr-comment.md
or theinline-pr-comment-with-diff.md
. In certain cases, this template is too big to be used as an environment variables on the Actions runner causing anError: Argument list too long
error.Describe the solution you’d like to see
I would like to see something like a
pr-comment-minimal.md
where you only show the comments and numbers without the big table with all the images and changes that happened.eg:
Describe alternatives you’ve considered
Alternative is to not use the output of this action on follow up actions (like the
create-pull-request
one).Additional context
N/A
The text was updated successfully, but these errors were encountered: