fix: headphones carousel example #754
Conversation
- react-native (0.71.8 -> 0.72.3) - react-native-reanimated (2.17.0 -> 3.3.0) - react-native-gradle-plugin (0.71.19 - added to android build)
| style={[ | ||
| styles.circle, | ||
| { | ||
| backgroundColor: color, |
There was a problem hiding this comment.
This it is the mentioned line part above. In addition to the component rendering according to the data length, the color swapping logic does not work correctly.
| @@ -590,6 +590,7 @@ | |||
| ); | |||
| MTL_ENABLE_DEBUG_INFO = YES; | |||
| ONLY_ACTIVE_ARCH = YES; | |||
| OTHER_CFLAGS = "$(inherited)"; | |||
There was a problem hiding this comment.
[high]: could you revert this change
| @@ -654,6 +655,7 @@ | |||
| "\"$(inherited)\"", | |||
| ); | |||
| MTL_ENABLE_DEBUG_INFO = NO; | |||
| OTHER_CFLAGS = "$(inherited)"; | |||
There was a problem hiding this comment.
[high]: could you revert this change
|
@CarlosSLoureiro could you resolve conflicts 🙏 Moreover, the iOS pipeline failed. Could you check that? |
|
@troZee I think it's done. |
| @@ -14,10 +14,10 @@ | |||
| "@react-navigation/native-stack": "~6.9.12", | |||
| "@react-navigation/stack": "~6.3.16", | |||
| "react": "18.2.0", | |||
| "react-native": "0.71.8", | |||
| "react-native": "0.72.3", | |||
There was a problem hiding this comment.
[high]: Could you revert that file?
There was a problem hiding this comment.
When I tried to run the interpolate in the background Color it doesn't worked in 0.71.8 version. That's why I've upgraded the react native version. Maybe it's a specific issue from the current used version in the example...
| @@ -2,17 +2,16 @@ PODS: | |||
| - boost (1.76.0) | |||
| - CocoaAsyncSocket (7.6.5) | |||
| - DoubleConversion (1.1.6) | |||
| - FBLazyVector (0.71.8) | |||
There was a problem hiding this comment.
[high]: Could you revert that file?
|
LGTM. Please address those 2 comments: |
Summary
Fix de logic of background color from circle component at the headphones carousel example.
Motivation
I've reading the code of the headphones carousel example and I understood that the color of the circle must change due to a code line will be mentioned below in this PR.
Test Plan
Just try to execute the mentioned example.
Checklist
README.md(yes, updated the readme gif example)