fix(ios): Fix vertical list scroll directionin rtl #885
+21
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troZee
requested changes
Oct 16, 2024
|
@DrRefactor could you provide any documentation for the RTL, when the component is scrollable vertically? |
DrRefactor
force-pushed
the
fix-rtl-vertical-scroll
branch
from
c8c700d
to
657c614
Compare
DrRefactor
force-pushed
the
fix-rtl-vertical-scroll
branch
from
657c614
to
6dd2f87
Compare
|
@troZee For vertically scrolled lists, there's basically no change in layout in RTL vs LTR. The only one difference in this case is when the vertically scrolled list is a grid, then the first element should be aligned to the right edge. |
troZee
requested changes
Oct 17, 2024
| @@ -309,6 +309,10 @@ - (BOOL)isLtrLayout { | |||
| return [_layoutDirection isEqualToString: @"ltr"]; | |||
| } | |||
|
|
|||
| - (BOOL)isHorizontalRtlLayout { | |||
There was a problem hiding this comment.
Could you extract this function to a separate file? It is used in two places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When in RTL, vertical pager view is scrolling backwards. This is unwanted behavior (only horizontal axis should be inverted in RTL).
Test Plan
Test LTR & RTL in legacy pager view.
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md