add component lib to top level folder #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jashaszun
requested changes
Oct 28, 2018
There was a problem hiding this comment.
- Remove the Firmware folder? It seems to have been pulled back in from last year.
- Have the project folder (BlackBox) at the top level with Firmware and Hardware underneath. Anything common between projects hardware- or firmware-wise should go in a common/ top-level folder (or some other similar name like core/). Also I'd prefer lowercase with underscores, so black_box/hardware/... etc.
Jashaszun
requested changes
Oct 28, 2018
There was a problem hiding this comment.
- SPI lines do not use pull-ups, except possibly for MISO. See https://electronics.stackexchange.com/questions/234703/spi-bus-termination-and-pull-up-resistors
Jashaszun
requested changes
Oct 28, 2018
There was a problem hiding this comment.
- Label the NRST pin on the left side of the BUTTONS section.
- Clean up the left side of the SDCARD_CONS section -- suggest switching the X split locations of MISO1 and MOSI1.
- For components with values (e.g. resistors, capacitors) show the values as well. Right click, properties, markings, additional markings -> Show: Value.
|
Should NRST not have a pull-up? Or is is just floating/ground? |
|
Please explain your idea for the accelerometer -- is it on another board? If so, it needs to be another schematic. |
neelayjunnarkar
requested changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.