Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add param extra_payload for VectorRetriever.process() #1161

Conversation

koch3092
Copy link
Collaborator

@koch3092 koch3092 commented Nov 8, 2024

Description

close #1149

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@koch3092 koch3092 linked an issue Nov 8, 2024 that may be closed by this pull request
2 tasks
@Wendong-Fan
Copy link
Member

hey @koch3092 , seems some pre commit check and unit test need to be double checked

@Wendong-Fan Wendong-Fan added the enhancement New feature or request label Nov 8, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 16 milestone Nov 8, 2024
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @koch3092 , added one more commit here: 94af400

@Wendong-Fan Wendong-Fan merged commit 7468dde into master Nov 8, 2024
6 checks passed
@Wendong-Fan Wendong-Fan deleted the 1149-feature-request-add-param-custom-payload-in-vectorretrieverprocess branch November 8, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add param custom payload in VectorRetriever.process()
2 participants