feat: update aws_bedrock #1194
feat: update aws_bedrock #1194
Conversation
|
Hi Shengsong, thanks for your contributing. Please update the Camel license in the code. |
There was a problem hiding this comment.
Thanks @Asher-hss ! Could you take a look at https://github.com/aws-samples/bedrock-access-gateway and verify whether we can use it to do a more simple integration? This would be more easier for us to maintain it if it works
| tool_choice (Union[dict[str, str], str], optional): The tool choice. | ||
| """ | ||
|
|
||
| max_tokens: Optional[int] = 400 |
There was a problem hiding this comment.
400 token is quiet limited, could we set this to None?
| maxTokens (int, optional): The maximum number of tokens. | ||
| temperatue (float, optional): Controls the randomness of the output. | ||
| top_p (float, optional): Use nucleus sampling. | ||
| top_k (int, optional): Use top-k sampling. | ||
| tool_choice (Union[dict[str, str], str], optional): The tool choice. |
There was a problem hiding this comment.
any reference link to AWS bedrock parameters? It seems the supported parameters are quite limited
There was a problem hiding this comment.
https://docs.aws.amazon.com/bedrock/latest/APIReference/API_runtime_InferenceConfiguration.html
Hi wendong，this is the reference link about aws bedrock parameters
I think we're good to go, interacting through OpenAI's client, which will be more beneficial for future maintenance. |
| api_key (Optional[str], optional): This parameter is not used. | ||
| url (Optional[str], optional): This parameter is not used. |
There was a problem hiding this comment.
| api_key (Optional[str], optional): This parameter is not used. | |
| url (Optional[str], optional): This parameter is not used. | |
| api_key (str, optional): This parameter is not used. | |
| url (str, optional): This parameter is not used. |
Corrected parameter type descriptions, and the purpose of these two parameters.
| api_key: Optional[str] = None, | ||
| url: Optional[str] = None, | ||
| token_counter: Optional[BaseTokenCounter] = None, | ||
| region_name: Optional[str] = "eu-west-2", |
There was a problem hiding this comment.
| region_name: Optional[str] = "eu-west-2", | |
| region_name: Optional[str] = "eu-west-2", | |
| **kwargs: Any, |
How about adding **kwargs, which can add some customizable items to boto3.client initialization
| service_name='bedrock-runtime', | ||
| region_name=region_name, | ||
| aws_access_key_id=access_key_id, | ||
| aws_secret_access_key=secret_access_key, |
There was a problem hiding this comment.
| aws_secret_access_key=secret_access_key, | |
| aws_secret_access_key=secret_access_key, | |
| **kwargs, |
|
|
||
| model = ModelFactory.create( | ||
| model_platform=ModelPlatformType.AWS_BEDROCK, | ||
| model_type="meta.llama3-70b-instruct-v1:0", |
There was a problem hiding this comment.
Add values in camel.types.enums.ModelType
Description
#1174
Motivation and Context
#1174
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!