Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created models subpackage #167

Merged
merged 9 commits into from
Jun 17, 2023
Merged

Created models subpackage #167

merged 9 commits into from
Jun 17, 2023

Conversation

Obs01ete
Copy link
Collaborator

@Obs01ete Obs01ete commented Jun 15, 2023 •
edited
Loading

Description

Follow up for the stub_model PR #161.

Types of changes

  • Refactoring
  • Documentation

@Obs01ete Obs01ete requested a review from lightaime June 15, 2023 18:13
@Obs01ete Obs01ete self-assigned this Jun 15, 2023
@Obs01ete Obs01ete mentioned this pull request Jun 15, 2023
Merged
4 tasks
lightaime
lightaime reviewed Jun 15, 2023
View reviewed changes
camel/model_backend.py Outdated Show resolved Hide resolved
camel/model_backend.py Outdated Show resolved Hide resolved
camel/model_backend.py Outdated Show resolved Hide resolved
camel/model_backend.py Outdated Show resolved Hide resolved
camel/model_backend.py Outdated Show resolved Hide resolved
lightaime
lightaime reviewed Jun 15, 2023
View reviewed changes
camel/model_backend.py Outdated Show resolved Hide resolved
lightaime
lightaime reviewed Jun 15, 2023
View reviewed changes
camel/model_backend.py Outdated Show resolved Hide resolved
@Obs01ete Obs01ete marked this pull request as ready for review June 15, 2023 20:37
@Obs01ete Obs01ete changed the title Docstrings for ModelFactory Created models subpackage Jun 15, 2023
@Obs01ete Obs01ete requested a review from lightaime June 15, 2023 20:41
lightaime
lightaime reviewed Jun 15, 2023
View reviewed changes
Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Left some small comments

camel/models/model_factory.py Outdated Show resolved Hide resolved
camel/models/openai_model.py Outdated Show resolved Hide resolved
camel/models/base_model.py Outdated Show resolved Hide resolved
camel/models/stub_model.py Outdated Show resolved Hide resolved
camel/models/__init__.py Outdated Show resolved Hide resolved
camel/models/__init__.py Outdated Show resolved Hide resolved
@Obs01ete Obs01ete linked an issue Jun 16, 2023 that may be closed by this pull request
Make a stub for OpenAI API to be used in tests #120
Closed
@Obs01ete Obs01ete requested a review from lightaime June 17, 2023 11:46
lightaime
lightaime reviewed Jun 17, 2023
View reviewed changes
Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some minor comments

camel/models/model_factory.py Outdated Show resolved Hide resolved
camel/models/stub_model.py Outdated Show resolved Hide resolved
camel/models/base_model.py Outdated Show resolved Hide resolved
@Obs01ete Obs01ete requested a review from lightaime June 17, 2023 14:00
lightaime
lightaime approved these changes Jun 17, 2023
View reviewed changes
test/test_model_backend.py Outdated Show resolved Hide resolved
@lightaime lightaime added the Model Related to backend models label Jun 17, 2023
@Obs01ete Obs01ete merged commit 6a27e23 into master Jun 17, 2023
9 checks passed
@Obs01ete Obs01ete deleted the stub_model_2 branch June 17, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightaime lightaime lightaime approved these changes

Assignees

@Obs01ete Obs01ete

Labels
Model Related to backend models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make a stub for OpenAI API to be used in tests
2 participants
@Obs01ete @lightaime