Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy errors #185

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix mypy errors #185

merged 1 commit into from
Jun 28, 2023

Conversation

Obs01ete
Copy link
Collaborator

Description

Cleanup a fraction of mypy errors.

Motivation and Context

We want to enable strict mypy check on the pre-commit hook in the future.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)

@Obs01ete Obs01ete marked this pull request as ready for review June 28, 2023 08:58
Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Obs01ete Obs01ete merged commit f4de3ff into master Jun 28, 2023
9 checks passed
@Obs01ete Obs01ete deleted the fix_mypy_2 branch June 28, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants