Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: memory support #255

Closed
wants to merge 33 commits into from
Closed

feat: memory support #255

wants to merge 33 commits into from

Conversation

Benjamin-eecs
Copy link
Member

@Benjamin-eecs Benjamin-eecs commented Aug 21, 2023

Description

Memory design in camel:

  • memory storage
  • memory types:
    • short-term
    • long-term

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Checklist

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Benjamin-eecs Benjamin-eecs changed the title feat: memory design feat: memory support Aug 21, 2023
@dandansamax
Copy link
Collaborator

dandansamax commented Aug 23, 2023

This is current memory design. I will push the basic code without examples and documents by the end of tomorrow.

Feel free to comment if you have any advise or question.

@Obs01ete
Copy link
Collaborator

Is it still a draft? Do you need a review?

@dandansamax
Copy link
Collaborator

Is it still a draft? Do you need a review?

Yes, it’s still a draft. I will request review when I think it’s almost done.😁

@dandansamax
Copy link
Collaborator

dandansamax commented Aug 27, 2023

Todo List:

  • Vector DB
    • Qdrant storage
    • Qdrant test
    • VectorDBMemory
    • VectorDBMemory test
    • Document
    • Exmaples
  • Chat History
    • Chat History Memory & test
    • Lossless storage & test
      • Json
      • In-memory
    • Document
    • Exmaples
  • Cognitive Memory
    • Implement
    • Test
    • Document
    • Exmaples
  • Embedding
    • OpenAI embedding
    • Test
    • Document

@dandansamax dandansamax marked this pull request as ready for review August 28, 2023 12:44
@dandansamax
Copy link
Collaborator

Most of the core code is done. I will keep updating the documentation and examples.

@dandansamax dandansamax marked this pull request as draft September 6, 2023 13:37
@dandansamax
Copy link
Collaborator

This PR has too many contents, so I divide it into several parts. The first step is ChatHistoryMemory and agent memory interaction, see #280.

@Obs01ete
Copy link
Collaborator

Okay, I've got the idea where it all is going

@Obs01ete Obs01ete removed their request for review September 19, 2023 11:36
@dandansamax
Copy link
Collaborator

This branch is the main branch for memory development. Close since it will not be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants