Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team photo aspect ratios are incorrect (need to be exactly square) #20

Closed
zhibek opened this issue Sep 5, 2016 · 2 comments
Closed
Assignees

Comments

@zhibek
Copy link
Member

zhibek commented Sep 5, 2016

The images used for the team photos are the wrong aspect ratio, which means they don't fill the circle correctly. The images need to be square (i.e. exactly the same width and height) so that no orange background colour is shown inside the circles.

Crop each profile photo so that it is exactly 160x160px (do not squeeze the images, simply crop the area to leave the area around the face of each person only). Currently the photos for Adham, Yassin and Reda have almost the right aspect ratio so they only need small changes, while the photos for everyone else (myself, Rashad, AbdElRahman, AbdElMoniem) need more cropping off the top/bottom of the image to make them work. We also need an image for Labib.

The screenshot below highlights the problem:
camelcase_website_team_photo_ratio

Please use this photo (its already square, it just needs to be resized to 160x160px) for this (when I get a better portrait photo, I'll replace this!):
john_portrait

ahmedReda1 pushed a commit that referenced this issue Sep 6, 2016
@ahmedelbougha
Copy link
Contributor

Reviewed

@ahmedelbougha ahmedelbougha assigned zhibek and unassigned ahmedelbougha Sep 7, 2016
@zhibek
Copy link
Member Author

zhibek commented Sep 8, 2016

Looks good - closing.

Noting the new related tickets #22 & #23.

@zhibek zhibek closed this as completed Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants