Skip to content

Commit

Permalink
Bump minimum node version to 18
Browse files Browse the repository at this point in the history
  • Loading branch information
@campersau
campersau committed Oct 21, 2023
1 parent 6d79b03 commit 1b2e1ca
Show file tree
Hide file tree
Showing 6 changed files with 27 additions and 27 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/bump.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'

- run: npm ci
- run: |
Expand Down
44 changes: 22 additions & 22 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: ['16', '18', '20']
node-version: ['18', '20', '21']
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}
# env:
Expand All @@ -25,25 +25,25 @@ jobs:

# linux dependencies
- run: sudo apt update && sudo apt install -y wine64
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
- run: wine --version
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
- run: sudo add-apt-repository ppa:git-core/ppa -y && sudo apt-get update -q && sudo apt-get install -y git
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '*'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '21'
# macos dependencies
# required for electron-packager
# - run: brew update && brew cask install xquartz wine-stable
# if: matrix.os == 'macos-latest' && matrix.node-version == '16'
# if: matrix.os == 'macos-latest' && matrix.node-version == '18'
# - run: wine64 --version
# if: matrix.os == 'macos-latest' && matrix.node-version == '16'
# if: matrix.os == 'macos-latest' && matrix.node-version == '18'
- run: brew reinstall git
if: matrix.os == 'macos-latest' && matrix.node-version == '*'
if: matrix.os == 'macos-latest' && matrix.node-version == '21'
# windows dependencies
# https://github.community/t5/GitHub-Actions/TEMP-is-broken-on-Windows/td-p/30432
- run: echo "TEMP=$env:USERPROFILE\AppData\Local\Temp" >> $env:GITHUB_ENV
if: matrix.os == 'windows-latest'
- run: choco upgrade git
if: matrix.os == 'windows-latest' && matrix.node-version == '*'
if: matrix.os == 'windows-latest' && matrix.node-version == '21'

- run: git --version
- run: git config --global user.email "test@testy.com"
Expand All @@ -52,92 +52,92 @@ jobs:

- run: npm ci
- run: npm run lint
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
- run: npm run build
- run: npm test

# publish artifacts
- run: npm pack
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
- run: npm run electronpackage -- --all
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
- run: npm run electronzip
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'

- name: Upload npm pack
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
uses: actions/upload-artifact@v3
with:
name: ungit
path: ungit-*.tgz
retention-days: 7

- name: Upload ungit-darwin-arm64
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
uses: actions/upload-artifact@v3
with:
name: ungit-darwin-arm64
path: dist/ungit-darwin-arm64.zip
retention-days: 7

- name: Upload ungit-darwin-x64
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
uses: actions/upload-artifact@v3
with:
name: ungit-darwin-x64
path: dist/ungit-darwin-x64.zip
retention-days: 7

- name: Upload ungit-linux-arm64
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
uses: actions/upload-artifact@v3
with:
name: ungit-linux-arm64
path: dist/ungit-linux-arm64.zip
retention-days: 7

- name: Upload ungit-linux-armv7l
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
uses: actions/upload-artifact@v3
with:
name: ungit-linux-armv7l
path: dist/ungit-linux-armv7l.zip
retention-days: 7

- name: Upload ungit-linux-x64
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
uses: actions/upload-artifact@v3
with:
name: ungit-linux-x64
path: dist/ungit-linux-x64.zip
retention-days: 7

- name: Upload ungit-win32-arm64
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
uses: actions/upload-artifact@v3
with:
name: ungit-win32-arm64
path: dist/ungit-win32-arm64.zip
retention-days: 7

- name: Upload ungit-win32-ia32
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
uses: actions/upload-artifact@v3
with:
name: ungit-win32-ia32
path: dist/ungit-win32-ia32.zip
retention-days: 7

- name: Upload ungit-win32-x64
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18'
uses: actions/upload-artifact@v3
with:
name: ungit-win32-x64
path: dist/ungit-win32-x64.zip
retention-days: 7

- name: npm publish
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16' && github.repository == 'FredrikNoren/ungit' && github.ref == 'refs/heads/master'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '18' && github.repository == 'FredrikNoren/ungit' && github.ref == 'refs/heads/master'
uses: actions/github-script@v6
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Quick intro to ungit: [https://youtu.be/hkBVAi3oKvo](https://youtu.be/hkBVAi3oKv

Installing
----------
Requires [node.js](https://nodejs.org) (≥ 16), [npm](https://www.npmjs.com/) (≥ 8.19.4, comes with node.js) and [git](https://git-scm.com/) (≥ 2.34.x). To install ungit just type:
Requires [node.js](https://nodejs.org) (≥ 18), [npm](https://www.npmjs.com/) (≥ 9.8.1, comes with node.js) and [git](https://git-scm.com/) (≥ 2.34.x). To install ungit just type:

npm install -g ungit

Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ image: Visual Studio 2022
environment:
matrix:
- nodejs_version: '' # latest
- nodejs_version: '20'
- nodejs_version: '18'
- nodejs_version: '16'

branches:
only:
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"supertest": "~6.3.3"
},
"engines": {
"node": ">=16"
"node": ">=18"
},
"license": "MIT",
"main": "public/main.js"
Expand Down

0 comments on commit 1b2e1ca

Please sign in to comment.