Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI config doesn't persist #20

Open
Ashoat opened this issue Sep 3, 2019 · 0 comments
Open

MIDI config doesn't persist #20

Ashoat opened this issue Sep 3, 2019 · 0 comments

Comments

@Ashoat
Copy link
Member

Ashoat commented Sep 3, 2019

When I initially wrote the code to store MIDI presets and config in SpectrumConfiguration, I knew that persisting them to XML would be an issue because I was using custom structs stored in collections.

  1. To make sure that the custom structs could be persisted to XML, I used XmlInclude annotations when declaring them
  2. The relationship between the MIDI config UI and SpectrumConfiguration is handled imperatively, and more than half of MainWindow.xaml.cs is dedicated to handling it
  3. In a lot of cases I call this.SaveConfig() manually to make sure that the config gets persisted. However, when debugging this issue at the burn, I added more SaveConfig calls, and they didn’t seem to correctly persist changes to the collections

I am pretty sure that this stuff was working when I first built it, given how much specific work I seemed to do to try and get it working. But it clearly isn’t working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant