Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dissoc with transient rows #153

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Conversation

camsaul
Copy link
Owner

@camsaul camsaul commented Oct 3, 2023

Fixes #105

Also:

  • fix contains? for transient instances
  • fix contains? when adding keys to transient rows
  • simplify transient row type, remove unneeded atom

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/toucan2/instance.clj 76.92% <100.00%> (+0.14%) ⬆️
src/toucan2/protocols.clj 65.62% <ø> (ø)
src/toucan2/jdbc/row.clj 64.06% <93.33%> (+7.07%) ⬆️

📢 Thoughts on this report? Let us know!.

@camsaul camsaul merged commit e8ac342 into master Oct 3, 2023
10 checks passed
@camsaul camsaul deleted the fix-dissoc-for-transient-rows branch October 3, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dissoc doesn't work correctly with TransientRow (in after-select, etc.)
1 participant