Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out log traces #193

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

alexander-yakushev
Copy link
Contributor

As discussed in #184, this solution is simpler and more efficient than that PR if the approach is viable.

10k rows benchmark against current master:

master:
Time per call: 7.49 ms   Alloc per call: 11,088,805b
Time per call: 7.45 ms   Alloc per call: 11,088,041b
Time per call: 7.63 ms   Alloc per call: 11,087,626b

no per-cell traces (10% improvement):
Time per call: 6.74 ms   Alloc per call: 11,086,952b
Time per call: 6.73 ms   Alloc per call: 11,086,286b
Time per call: 6.73 ms   Alloc per call: 11,085,933b

No per-row traces (another 14% improvement):
Time per call: 5.63 ms   Alloc per call: 11,085,107b
Time per call: 5.83 ms   Alloc per call: 11,084,783b
Time per call: 5.63 ms   Alloc per call: 11,084,576b

At first I thought to remove only the per-cell traces but the per-row ones are contributing quite a lot still.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.58%. Comparing base (3729d20) to head (5fe0504).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files          37       37           
  Lines        2498     2498           
  Branches      212      212           
=======================================
  Hits         2088     2088           
  Misses        198      198           
  Partials      212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camsaul camsaul merged commit a341f76 into camsaul:master Oct 30, 2024
10 checks passed
@alexander-yakushev alexander-yakushev deleted the comment-traces branch October 31, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants