Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Optimize to monorepo release notes #957

Closed
wants to merge 2 commits into from

Conversation

misiekhardcore
Copy link

@misiekhardcore misiekhardcore commented Oct 14, 2024

This PR adds Optimize to the release note generation.

related to camunda/camunda#22258

@misiekhardcore
Copy link
Author

I think the GH token is missing permissions to read from camunda/camunda-optimize repository

@aabouzaid
Copy link
Member

LGTM, but I will leave this to @jessesimpson36 as he worked on it more and has more details about it.

@aabouzaid aabouzaid removed their request for review October 15, 2024 11:05
@jessesimpson36
Copy link
Contributor

Won't optimize be part of the monorepo for future releases and not camunda-optimize?

@misiekhardcore
Copy link
Author

@jessesimpson36 Optimize is a part of the monorepo already but we are not a part of the single jar yet. The plan is to make it part of the single jar soon-ish. Does this mean that this PR is not needed?

@jessesimpson36
Copy link
Contributor

It looks like the release notes in the monorepo don't have any content.
https://github.com/camunda/camunda/releases/tag/8.6.0-optimize

for the release notes tool inside this repo, it needs a source with actual release notes. If that's in the camunda/camunda repo, then this repo should fetch from there instead of camunda-optimize. I would suggest figuring out how the release notes will be in the camunda/camunda repo before trying to change the camunda-platform repo.

@misiekhardcore
Copy link
Author

Okay, I close this for now until we get clearer view on what needs to be done here especially that the release notes generation is looked into in general in the monorepo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants