Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define test for pipelines in airgapped #912

Merged
merged 3 commits into from
May 31, 2024

Conversation

NohaIhab
Copy link
Contributor

part of #898

Summary

  • adds a notebook with a sample pipeline to test in airgapped
  • adds the pipelines-runner image to use in the test
  • adds README.md for pipelines test
  • adds README.md for pipelines-runner image
  • modifies the get-all-images.sh script to include the pipelines-runner image

@NohaIhab NohaIhab requested a review from a team as a code owner May 29, 2024 21:45
@kimwnasptd
Copy link
Contributor

LGTM and the notebook is as expected from
https://github.com/kubeflow/pipelines/blob/2.0.5/samples/tutorials/Data%20passing%20in%20python%20components/Data%20passing%20in%20python%20components%20-%20Files.py

I'll hold the merge until #908, #907 and #904 are merged, to test this one as well

Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we are really closing #898. The issue says here that we want to test also other components like Katib, Kserve. I think its important to cover katib because of the problems we were facing with EKS AKS UATs. Will there be some othe PRS to follow?

@NohaIhab
Copy link
Contributor Author

@misohu indeed this PR does not close the issue, it is planned to have follow-up PRs for other components.

Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :)

@NohaIhab NohaIhab merged commit 12e1ba2 into main May 31, 2024
@NohaIhab NohaIhab deleted the kf-5721-define-test-for-pipelines-in-airgapped branch May 31, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants