Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

feat: Add networking section in reference #158

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Oct 24, 2023

Description

Adding a generic network diagram for 5G architecture including protocols and endpoints under reference section.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gatici gatici requested a review from a team as a code owner October 24, 2023 12:12
@gatici gatici force-pushed the TELCO-846-Add-networking-section branch from 84c4d9d to aaf74e2 Compare October 24, 2023 12:15
docs/images/5g_network_architecture.png Outdated Show resolved Hide resolved
docs/reference/networking.md Outdated Show resolved Hide resolved
@gatici gatici force-pushed the TELCO-846-Add-networking-section branch 2 times, most recently from 40d3330 to aac2f5e Compare October 25, 2023 12:28
@gatici gatici requested review from markbeierl, gruyaume and ghislainbourgeois and removed request for markbeierl October 25, 2023 12:31
@gatici gatici force-pushed the TELCO-846-Add-networking-section branch from aac2f5e to 2d12645 Compare October 25, 2023 13:07
Copy link
Contributor

@ghislainbourgeois ghislainbourgeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a missing period, otherwise LGTM

docs/reference/networking.md Outdated Show resolved Hide resolved
@gatici gatici force-pushed the TELCO-846-Add-networking-section branch from 2d12645 to dad959d Compare October 25, 2023 19:20
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici force-pushed the TELCO-846-Add-networking-section branch from dad959d to d6c5a53 Compare October 25, 2023 19:23
@gatici gatici requested a review from gruyaume October 25, 2023 19:27
@gatici gatici force-pushed the TELCO-846-Add-networking-section branch from 7e7bc3a to de33bb2 Compare October 26, 2023 09:31
docs/reference/networking.md Outdated Show resolved Hide resolved
docs/reference/networking.md Outdated Show resolved Hide resolved
@gatici gatici force-pushed the TELCO-846-Add-networking-section branch 2 times, most recently from d6abec5 to 953cf09 Compare October 26, 2023 23:01
@gatici gatici requested a review from gruyaume October 26, 2023 23:02
docs/reference/networking.md Outdated Show resolved Hide resolved
docs/reference/networking.md Show resolved Hide resolved
docs/reference/networking.md Outdated Show resolved Hide resolved
@gatici gatici force-pushed the TELCO-846-Add-networking-section branch 2 times, most recently from dda8fb1 to a685622 Compare October 27, 2023 14:47
@gatici gatici requested a review from gruyaume October 27, 2023 14:47
Copy link
Collaborator

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise looks good

docs/.wordlist.txt Outdated Show resolved Hide resolved
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici force-pushed the TELCO-846-Add-networking-section branch from a685622 to 7fbbd3a Compare October 27, 2023 18:29
@gatici gatici merged commit 7e37f6c into main Oct 27, 2023
7 checks passed
@gatici gatici deleted the TELCO-846-Add-networking-section branch October 27, 2023 18:32
markbeierl pushed a commit that referenced this pull request Dec 15, 2023
Signed-off-by: gatici <gulsum.atici@canonical.com>
markbeierl added a commit that referenced this pull request Dec 15, 2023
Minor rework, spelling

Using mgmt instead of k8s.priv

Reorganization
New directory structure per tutorial
Multi page for CUPS

Fixing typo finally

Fleshing out details

Added nore IP address info, started on configure and updated observability
to include user-plane

chore: Adds semantic PR title validation (#159)

feat: Add networking section in reference (#158)

Signed-off-by: gatici <gulsum.atici@canonical.com>

feat: SD-Core CUPS howto (#149)

Co-authored-by: Ghislain Bourgeois <ghislain.bourgeois@canonical.com>
Co-authored-by: Guillaume Belanger <guillaume.belanger@canonical.com>

feat: Standardises section naming and ordering (#161)

feat: Add how to enable hugepages (#160)

Signed-off-by: gatici <gulsum.atici@canonical.com>
Co-authored-by: Daniel Arndt <daniel.arndt@canonical.com>

fix: Fix QoS bitrate missing unit in tutorial (#162)

fix: Removes plmnid parameter from subscriber creation (#163)

docs: Moves tutorial content to "getting started" (#165)

docs: Uses charmed 5G specific networking content (#166)

feat: Add backup and restore procedures (#167)

docs: Removes unnecessary content from tutorial (#168)

Rework to match new structure

Fixing spelliing

Updated to single file

Fixing spelling

Removing duplicate images

Rename to Mastering

Removing duplicate statement

docs: Combines all MicroK8s related commands in 1 step (#169)

docs: Separates day 1 from day 2 operations (#170)

docs: Changes doc to use subnet instead of ip (#172)

docs: Uses NMS instead of curls for managing sd-core (#173)

Fixing heading levels

Removed unnecessary note.  UPF IP is not needed

fix: Fixing typo in tutorial (#174)

chore: Adding details about how to access Grafana (#175)

chore: update default device group name (#176)

Updates to use NMS

Image for mastering tutorial

Spelling corrections

Adding user to microk8s group

Ingnoring http://*.mgmt for link checks

docs: Uses nipio instead of /etc/hosts (#177)

docs: Rename HugePages how-to and add steps to enable HugePages in host (#171)

Update docs/tutorials/mastering.md

Co-authored-by: Bartlomiej Gmerek <42570669+Gmerold@users.noreply.github.com>

Update docs/tutorials/mastering.md

Co-authored-by: Guillaume Belanger <guillaume.belanger@canonical.com>

Update docs/tutorials/mastering.md

Co-authored-by: Guillaume Belanger <guillaume.belanger@canonical.com>

Updates MACVLAN for reboot

Removing IMSI

Update to correct -k8s names
markbeierl added a commit that referenced this pull request Dec 15, 2023
Minor rework, spelling

Using mgmt instead of k8s.priv

Reorganization
New directory structure per tutorial
Multi page for CUPS

Fixing typo finally

Fleshing out details

Added nore IP address info, started on configure and updated observability
to include user-plane

chore: Adds semantic PR title validation (#159)

feat: Add networking section in reference (#158)

Signed-off-by: gatici <gulsum.atici@canonical.com>

feat: SD-Core CUPS howto (#149)

Co-authored-by: Ghislain Bourgeois <ghislain.bourgeois@canonical.com>
Co-authored-by: Guillaume Belanger <guillaume.belanger@canonical.com>

feat: Standardises section naming and ordering (#161)

feat: Add how to enable hugepages (#160)

Signed-off-by: gatici <gulsum.atici@canonical.com>
Co-authored-by: Daniel Arndt <daniel.arndt@canonical.com>

fix: Fix QoS bitrate missing unit in tutorial (#162)

fix: Removes plmnid parameter from subscriber creation (#163)

docs: Moves tutorial content to "getting started" (#165)

docs: Uses charmed 5G specific networking content (#166)

feat: Add backup and restore procedures (#167)

docs: Removes unnecessary content from tutorial (#168)

Rework to match new structure

Fixing spelliing

Updated to single file

Fixing spelling

Removing duplicate images

Rename to Mastering

Removing duplicate statement

docs: Combines all MicroK8s related commands in 1 step (#169)

docs: Separates day 1 from day 2 operations (#170)

docs: Changes doc to use subnet instead of ip (#172)

docs: Uses NMS instead of curls for managing sd-core (#173)

Fixing heading levels

Removed unnecessary note.  UPF IP is not needed

fix: Fixing typo in tutorial (#174)

chore: Adding details about how to access Grafana (#175)

chore: update default device group name (#176)

Updates to use NMS

Image for mastering tutorial

Spelling corrections

Adding user to microk8s group

Ingnoring http://*.mgmt for link checks

docs: Uses nipio instead of /etc/hosts (#177)

docs: Rename HugePages how-to and add steps to enable HugePages in host (#171)

Update docs/tutorials/mastering.md

Co-authored-by: Bartlomiej Gmerek <42570669+Gmerold@users.noreply.github.com>

Update docs/tutorials/mastering.md

Co-authored-by: Guillaume Belanger <guillaume.belanger@canonical.com>

Update docs/tutorials/mastering.md

Co-authored-by: Guillaume Belanger <guillaume.belanger@canonical.com>

Updates MACVLAN for reboot

Removing IMSI

Update to correct -k8s names
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants