This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add networking section in reference #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatici
force-pushed
the
TELCO-846-Add-networking-section
branch
from
October 24, 2023 12:15
84c4d9d
to
aaf74e2
Compare
gruyaume
reviewed
Oct 24, 2023
ghislainbourgeois
suggested changes
Oct 24, 2023
gatici
force-pushed
the
TELCO-846-Add-networking-section
branch
2 times, most recently
from
October 25, 2023 12:28
40d3330
to
aac2f5e
Compare
gatici
requested review from
markbeierl,
gruyaume and
ghislainbourgeois
and removed request for
markbeierl
October 25, 2023 12:31
gatici
force-pushed
the
TELCO-846-Add-networking-section
branch
from
October 25, 2023 13:07
aac2f5e
to
2d12645
Compare
ghislainbourgeois
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a missing period, otherwise LGTM
gruyaume
suggested changes
Oct 25, 2023
gatici
force-pushed
the
TELCO-846-Add-networking-section
branch
from
October 25, 2023 19:20
2d12645
to
dad959d
Compare
Signed-off-by: gatici <gulsum.atici@canonical.com>
gatici
force-pushed
the
TELCO-846-Add-networking-section
branch
from
October 25, 2023 19:23
dad959d
to
d6c5a53
Compare
gatici
force-pushed
the
TELCO-846-Add-networking-section
branch
from
October 26, 2023 09:31
7e7bc3a
to
de33bb2
Compare
gruyaume
suggested changes
Oct 26, 2023
gruyaume
reviewed
Oct 26, 2023
gatici
force-pushed
the
TELCO-846-Add-networking-section
branch
2 times, most recently
from
October 26, 2023 23:01
d6abec5
to
953cf09
Compare
gruyaume
suggested changes
Oct 27, 2023
gatici
force-pushed
the
TELCO-846-Add-networking-section
branch
2 times, most recently
from
October 27, 2023 14:47
dda8fb1
to
a685622
Compare
gruyaume
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, otherwise looks good
Signed-off-by: gatici <gulsum.atici@canonical.com>
gatici
force-pushed
the
TELCO-846-Add-networking-section
branch
from
October 27, 2023 18:29
a685622
to
7fbbd3a
Compare
markbeierl
pushed a commit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: gatici <gulsum.atici@canonical.com>
markbeierl
added a commit
that referenced
this pull request
Dec 15, 2023
Minor rework, spelling Using mgmt instead of k8s.priv Reorganization New directory structure per tutorial Multi page for CUPS Fixing typo finally Fleshing out details Added nore IP address info, started on configure and updated observability to include user-plane chore: Adds semantic PR title validation (#159) feat: Add networking section in reference (#158) Signed-off-by: gatici <gulsum.atici@canonical.com> feat: SD-Core CUPS howto (#149) Co-authored-by: Ghislain Bourgeois <ghislain.bourgeois@canonical.com> Co-authored-by: Guillaume Belanger <guillaume.belanger@canonical.com> feat: Standardises section naming and ordering (#161) feat: Add how to enable hugepages (#160) Signed-off-by: gatici <gulsum.atici@canonical.com> Co-authored-by: Daniel Arndt <daniel.arndt@canonical.com> fix: Fix QoS bitrate missing unit in tutorial (#162) fix: Removes plmnid parameter from subscriber creation (#163) docs: Moves tutorial content to "getting started" (#165) docs: Uses charmed 5G specific networking content (#166) feat: Add backup and restore procedures (#167) docs: Removes unnecessary content from tutorial (#168) Rework to match new structure Fixing spelliing Updated to single file Fixing spelling Removing duplicate images Rename to Mastering Removing duplicate statement docs: Combines all MicroK8s related commands in 1 step (#169) docs: Separates day 1 from day 2 operations (#170) docs: Changes doc to use subnet instead of ip (#172) docs: Uses NMS instead of curls for managing sd-core (#173) Fixing heading levels Removed unnecessary note. UPF IP is not needed fix: Fixing typo in tutorial (#174) chore: Adding details about how to access Grafana (#175) chore: update default device group name (#176) Updates to use NMS Image for mastering tutorial Spelling corrections Adding user to microk8s group Ingnoring http://*.mgmt for link checks docs: Uses nipio instead of /etc/hosts (#177) docs: Rename HugePages how-to and add steps to enable HugePages in host (#171) Update docs/tutorials/mastering.md Co-authored-by: Bartlomiej Gmerek <42570669+Gmerold@users.noreply.github.com> Update docs/tutorials/mastering.md Co-authored-by: Guillaume Belanger <guillaume.belanger@canonical.com> Update docs/tutorials/mastering.md Co-authored-by: Guillaume Belanger <guillaume.belanger@canonical.com> Updates MACVLAN for reboot Removing IMSI Update to correct -k8s names
markbeierl
added a commit
that referenced
this pull request
Dec 15, 2023
Minor rework, spelling Using mgmt instead of k8s.priv Reorganization New directory structure per tutorial Multi page for CUPS Fixing typo finally Fleshing out details Added nore IP address info, started on configure and updated observability to include user-plane chore: Adds semantic PR title validation (#159) feat: Add networking section in reference (#158) Signed-off-by: gatici <gulsum.atici@canonical.com> feat: SD-Core CUPS howto (#149) Co-authored-by: Ghislain Bourgeois <ghislain.bourgeois@canonical.com> Co-authored-by: Guillaume Belanger <guillaume.belanger@canonical.com> feat: Standardises section naming and ordering (#161) feat: Add how to enable hugepages (#160) Signed-off-by: gatici <gulsum.atici@canonical.com> Co-authored-by: Daniel Arndt <daniel.arndt@canonical.com> fix: Fix QoS bitrate missing unit in tutorial (#162) fix: Removes plmnid parameter from subscriber creation (#163) docs: Moves tutorial content to "getting started" (#165) docs: Uses charmed 5G specific networking content (#166) feat: Add backup and restore procedures (#167) docs: Removes unnecessary content from tutorial (#168) Rework to match new structure Fixing spelliing Updated to single file Fixing spelling Removing duplicate images Rename to Mastering Removing duplicate statement docs: Combines all MicroK8s related commands in 1 step (#169) docs: Separates day 1 from day 2 operations (#170) docs: Changes doc to use subnet instead of ip (#172) docs: Uses NMS instead of curls for managing sd-core (#173) Fixing heading levels Removed unnecessary note. UPF IP is not needed fix: Fixing typo in tutorial (#174) chore: Adding details about how to access Grafana (#175) chore: update default device group name (#176) Updates to use NMS Image for mastering tutorial Spelling corrections Adding user to microk8s group Ingnoring http://*.mgmt for link checks docs: Uses nipio instead of /etc/hosts (#177) docs: Rename HugePages how-to and add steps to enable HugePages in host (#171) Update docs/tutorials/mastering.md Co-authored-by: Bartlomiej Gmerek <42570669+Gmerold@users.noreply.github.com> Update docs/tutorials/mastering.md Co-authored-by: Guillaume Belanger <guillaume.belanger@canonical.com> Update docs/tutorials/mastering.md Co-authored-by: Guillaume Belanger <guillaume.belanger@canonical.com> Updates MACVLAN for reboot Removing IMSI Update to correct -k8s names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a generic network diagram for 5G architecture including protocols and endpoints under reference section.
Checklist: