Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-3017] Patch Pebble issue on shutdown on failure #54

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

welpaolo
Copy link
Collaborator

@welpaolo welpaolo commented Nov 10, 2023

This PR provides a hot fix to allow the image to return a non-zero code should the spark job fail. This PR should only be delivered on edge images as a similar UX should be natively provided by pebble

@deusebio deusebio requested review from grobbie and deusebio November 14, 2023 09:54
@deusebio deusebio changed the title Add test to validate wrong behavior of pebble in case of an error occurred in the spark program [DPE-3017] Patch Pebble issue on shutdown on failure Nov 14, 2023
Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

Copy link

@grobbie grobbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deusebio deusebio merged commit 427c046 into 3.4-22.04/edge Nov 16, 2023
3 checks passed
@deusebio deusebio deleted the test-pebble-failure branch November 16, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants