Initial version of testing SRIOV on Intel Netork Devices

Adding SRIOV container tests

Add flake8 format errors.

Adding sriov tests to testing framework

Fix the virtualizaion function call with the correct parameters

Add Unit tests
Update minor changes found by the Unit Testa

Updated the unit tests for flake8 format

Removed the call to setup.   Setup is not called when the test runs on
images less than 24.04

providers/base/tests/test_virtualization.py

@@ -20,7 +20,7 @@
 from unittest import TestCase
 from unittest.mock import patch, MagicMock
 
-from virtualization import LXDTest_vm
+from virtualization import LXDTest_vm, LXDTest_sriov
 
 
 class TestLXDTest_vm(TestCase):
@@ -217,3 +217,185 @@ def test_setup_failure(self):
         setup_return = LXDTest_vm.setup(self_mock)
 
         self.assertFalse(setup_return)
+
+
+class TestLXDTest_sriov(TestCase):
+    @patch("virtualization.logging")
+    @patch("virtualization.RunCommand")
+    def test_run_command_no_stderr(self, run_command_mock, logging_mock):
+        task = run_command_mock()
+        task.returncode = 0
+        task.stdout = "abc"
+        task.stderr = None
+
+        command_result = LXDTest_sriov.run_command(
+            MagicMock(), "command", log_stderr=True
+        )
+
+        self.assertTrue(logging_mock.debug.called)
+        self.assertTrue(command_result)
+
+    @patch("virtualization.logging")
+    @patch("virtualization.RunCommand")
+    def test_run_command_no_log_stderr(self, run_command_mock, logging_mock):
+        task = run_command_mock()
+        task.returncode = 1
+        task.stdout = "abc"
+        task.stderr = None
+
+        command_result = LXDTest_sriov.run_command(
+            MagicMock(), "command", log_stderr=False
+        )
+
+        self.assertFalse(command_result)
+
+    @patch("virtualization.logging")
+    @patch("virtualization.RunCommand")
+    def test_run_command_error(self, run_command_mock, logging_mock):
+        task = run_command_mock()
+        task.returncode = 1
+        task.stdout = "abc"
+        task.stderr = "some error"
+
+        command_result = LXDTest_sriov.run_command(
+            MagicMock(), "command", log_stderr=True
+        )
+
+        self.assertTrue(logging_mock.error.called)
+        self.assertFalse(command_result)
+
+    @patch("virtualization.logging")
+    @patch("virtualization.RunCommand")
+    def test_run_command_ok(self, run_command_mock, logging_mock):
+        task = run_command_mock()
+        task.returncode = 0
+        task.stdout = "abc"
+        task.stderr = "some error"
+
+        command_result = LXDTest_sriov.run_command(
+            MagicMock(), "command", log_stderr=True
+        )
+
+        self.assertTrue(logging_mock.debug.called)
+        self.assertTrue(command_result)
+
+    @patch("virtualization.logging")
+    @patch("virtualization.RunCommand")
+    def test_run_command_ok_no_stdout(self, run_command_mock, logging_mock):
+        task = run_command_mock()
+        task.returncode = 0
+        task.stdout = ""
+        task.stderr = "some error"
+
+        command_result = LXDTest_sriov.run_command(
+            MagicMock(), "command", log_stderr=True
+        )
+
+        self.assertTrue(logging_mock.debug.called)
+        self.assertTrue(command_result)
+
+    @patch("virtualization.logging")
+    def test_cleanup(self, logging_mock):
+        self_mock = MagicMock()
+        LXDTest_sriov.cleanup(self_mock)
+
+        self.assertTrue(self_mock.run_command.called)
+
+    @patch("virtualization.logging")
+    def test_start_sriov_fail_setup(self, logging_mock):
+        self_mock = MagicMock()
+        self_mock.setup.return_value = False
+
+        start_result = LXDTest_sriov.start_sriov(self_mock)
+        self.assertFalse(start_result)
+
+    @patch("virtualization.logging")
+    def test_start_sriov_fail_init_no_img_alias(self, logging_mock):
+        self_mock = MagicMock()
+        self_mock.setup.return_value = True
+        self_mock.image_url = None
+        self_mock.template_url = None
+        self_mock.network_name = "sriov_network"
+        self_mock.test_type = "vm"
+        self_mock.name = "testbed"
+        self_mock.run_command.side_effect = [False]
+
+        start_result = LXDTest_sriov.start_sriov(self_mock)
+        self.assertFalse(start_result)
+
+    @patch("virtualization.logging")
+    def test_start_sriov_fail_start(self, logging_mock):
+        self_mock = MagicMock()
+        self_mock.setup.return_value = True
+        self_mock.image_url = "image url"
+        self_mock.template_url = "template url"
+        self_mock.network_name = "sriov_network"
+        self_mock.test_type = "vm"
+        self_mock.name = "testbed"
+        self_mock.run_command.side_effect = [True, False]
+
+        start_result = LXDTest_sriov.start_sriov(self_mock)
+        self.assertFalse(start_result)
+
+    @patch("virtualization.logging")
+    def test_start_sriov_fail_list(self, logging_mock):
+        self_mock = MagicMock()
+        self_mock.setup.return_value = True
+        self_mock.image_url = "image url"
+        self_mock.template_url = "template url"
+        self_mock.network_name = "sriov_network"
+        self_mock.test_type = "vm"
+        self_mock.name = "testbed"
+        self_mock.run_command.side_effect = [True, True, False]
+
+        start_result = LXDTest_sriov.start_sriov(self_mock)
+        self.assertFalse(start_result)
+
+    @patch("time.sleep")
+    @patch("virtualization.logging")
+    def test_start_sriov_fail_exec(self, logging_mock, time_sleep_mock):
+        self_mock = MagicMock()
+        self_mock.setup.return_value = False
+        self_mock.image_url = "image url"
+        self_mock.template_url = "template url"
+        self_mock.network_name = "sriov_network"
+        self_mock.test_type = "vm"
+        self_mock.name = "testbed"
+        self_mock.run_command.side_effect = itertools.chain(
+            [True, True, True], itertools.repeat(False)
+        )
+
+        start_result = LXDTest_sriov.start_sriov(self_mock)
+        self.assertFalse(start_result)
+
+    @patch("time.sleep")
+    @patch("virtualization.print")
+    @patch("virtualization.logging")
+    def test_start_sriov_success(self, logging_mock, print_mock, time_sleep_mock):
+        self_mock = MagicMock()
+        self_mock.setup.return_value = True
+        self_mock.image_url = "image url"
+        self_mock.template_url = "template url"
+        self_mock.network_name = "sriov_network"
+        self_mock.test_type = "vm"
+        self_mock.name = "testbed"
+        self_mock.run_command.side_effect = itertools.chain(
+            [True, True, True], itertools.repeat(False)
+        )
+
+        start_result = LXDTest_sriov.start_sriov(self_mock)
+
+        self.assertFalse(start_result)
+        self.assertTrue(print_mock.called)
+
+    def test_setup_failure(self):
+        self_mock = MagicMock()
+        self_mock.run_command.return_value = False
+        self_mock.image_url = None
+        self_mock.template_url = None
+        self_mock.network_name = None
+        self_mock.test_type = None
+
+        setup_return = LXDTest_sriov.setup(self_mock)
+
+        self.assertFalse(setup_return)

providers/base/units/virtualization/jobs.pxu

@@ -25,3 +25,31 @@ _purpose:
  Verifies that an LXD container can be created and launched
 _summary:
  Verify LXD container launches
+
+plugin: shell
+category_id: com.canonical.plainbox::virtualization
+id: virtualization/verify_lxd_vm_sriov
+environ: LXD_TEMPLATE KVM_IMAGE
+estimated_duration: 60.0
+requires:
+ executable.name == 'lxc'
+ package.name == 'lxd-installer' or snap.name == 'lxd'
+command: virtualization.py --debug sriov --type vm
+_purpose:
+ Verifies that an SRIOV network device was created on an LXD Virtual Machine
+_summary:
+ Verify SRIOV on LXD Virtual Machine 
+
+plugin: shell
+category_id: com.canonical.plainbox::virtualization
+id: virtualization/verify_lxd_container_sriov
+environ: LXD_TEMPLATE LXD_ROOTFS
+estimated_duration: 60.0
+requires:
+ executable.name == 'lxc'
+ package.name == 'lxd-installer' or snap.name == 'lxd'
+command: virtualization.py --debug sriov --type container
+_purpose:
+ Verifies that an SRIOV network device was created on an LXD Container
+_summary:
+ Verify SRIOV on LXD Container 

providers/base/units/virtualization/test-plan.pxu

@@ -17,3 +17,5 @@ _name: Automated virtualization tests
 include:
     virtualization/verify_lxd
     virtualization/verify_lxd_vm
+    virtualization/verify_lxd_vm_sriov
+    virtualization/verify_lxd_container_sriov

providers/certification-server/units/server-full.pxu

@@ -25,6 +25,8 @@ include:
     stress/cpu_stress_ng_test                  certification-status=blocker
     virtualization/verify_lxd                  certification-status=blocker
     virtualization/verify_lxd_vm               certification-status=blocker
+    virtualization/verify_lxd_vm_sriov         certification-status=non-blocker
+    virtualization/verify_lxd_container_sriov  certification-status=non-blocker    
     info/kvm_output                            certification-status=non-blocker
     miscellanea/oops                           certification-status=blocker
     miscellanea/oops_results.log

providers/certification-server/units/server-functional.pxu

@@ -23,6 +23,8 @@ include:
     power-management/rtc                       certification-status=blocker
     virtualization/verify_lxd                  certification-status=blocker
     virtualization/verify_lxd_vm               certification-status=blocker
+    virtualization/verify_lxd_vm_sriov         certification-status=non-blocker
+    virtualization/verify_lxd_container_sriov  certification-status=non-blocker    
     info/kvm_output                            certification-status=non-blocker
     miscellanea/oops                           certification-status=non-blocker
     miscellanea/oops_results.log               certification-status=non-blocker

providers/certification-server/units/server-regression.pxu

@@ -24,6 +24,8 @@ include:
     usb/detect                                 certification-status=non-blocker
     virtualization/verify_lxd                  certification-status=blocker
     virtualization/verify_lxd_vm               certification-status=blocker
+    virtualization/verify_lxd_vm_sriov         certification-status=non-blocker
+    virtualization/verify_lxd_container_sriov  certification-status=non-blocker    
     info/kvm_output                            certification-status=non-blocker
     miscellanea/oops                           certification-status=blocker
     miscellanea/oops_results.log

providers/certification-server/units/server-soc-cert.pxu

@@ -23,6 +23,8 @@ include:
     stress/cpu_stress_ng_test                  certification-status=blocker
     virtualization/verify_lxd                  certification-status=blocker
     virtualization/verify_lxd_vm               certification-status=blocker
+    virtualization/verify_lxd_vm_sriov         certification-status=non-blocker
+    virtualization/verify_lxd_container_sriov  certification-status=non-blocker    
     info/kvm_output                            certification-status=non-blocker
     miscellanea/oops                           certification-status=non-blocker
     miscellanea/oops_results.log

providers/certification-server/units/server-ubuntucore-20.pxu

@@ -39,6 +39,8 @@ include:
   usb3/storage-preinserted                   certification-status=blocker
   virtualization/verify_lxd                  certification-status=blocker
   virtualization/verify_lxd_vm               certification-status=blocker
+  virtualization/verify_lxd_vm_sriov         certification-status=non-blocker
+  virtualization/verify_lxd_container_sriov  certification-status=non-blocker  
   info/kvm_output                            certification-status=non-blocker
   miscellanea/oops                           certification-status=blocker
   miscellanea/oops_results.log

providers/certification-server/units/virtualization-only.pxu

@@ -13,6 +13,8 @@ include:
     info/hdparm_.*.txt                         certification-status=non-blocker
     virtualization/verify_lxd                  certification-status=blocker
     virtualization/verify_lxd_vm               certification-status=blocker
+    virtualization/verify_lxd_vm_sriov         certification-status=non-blocker
+    virtualization/verify_lxd_container_sriov  certification-status=non-blocker
     info/kvm_output                            certification-status=non-blocker
     miscellanea/oops                           certification-status=non-blocker
     miscellanea/oops_results.log               certification-status=non-blocker