Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider ID_INPUT_POINTINGSTICK as touchpad (BugFix) #1447

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Consider ID_INPUT_POINTINGSTICK as touchpad (BugFix) #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions checkbox-support/checkbox_support/parsers/tests/test_udevadm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,9 @@ def test_TOSHIBA_NVME(self):
self.assertEqual(self.count(devices, "VIDEO"), 2)
self.assertEqual(self.count(devices, "AUDIO"), 2)
self.assertEqual(self.count(devices, "KEYBOARD"), 1)
self.assertEqual(self.count(devices, "TOUCHPAD"), 1)
self.assertEqual(self.count(devices, "TOUCHPAD"), 2)
self.assertEqual(self.count(devices, "CARDREADER"), 1)
self.assertEqual(self.count(devices, "MOUSE"), 1)
self.assertEqual(self.count(devices, "MOUSE"), 0)
Comment on lines +358 to +360
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right.

I went and check what device this udev DB came from, and it is a Dell Latitude 5580 which comes with a trackpoint, similar to the ones on the Lenovo laptops.

I asked one of our colleagues and they provided a sample of a Lenovo unit with such a trackpoint:

4649 P: /devices/pci0000:00/0000:00:1f.4/i2c-0/0-0015/input/input8
4650 L: 0
4651 E: DEVPATH=/devices/pci0000:00/0000:00:1f.4/i2c-0/0-0015/input/input8
4652 E: SUBSYSTEM=input
4653 E: PRODUCT=18/4f3/67/0
4654 E: NAME="Elan TrackPoint"
4655 E: PROP=21
4656 E: EV=7
4657 E: KEY=70000 0 0 0 0
4658 E: REL=3
4659 E: MODALIAS=input:b0018v04F3p0067e0000-e0,1,2,k110,111,112,r0,1,amlsfw
4660 E: USEC_INITIALIZED=3293319
4661 E: ID_INPUT=1
4662 E: ID_INPUT_POINTINGSTICK=1
4663 E: ID_INPUT_MOUSE=1
4664 E: ID_SERIAL=noserial
4665 E: ID_PATH=pci-0000:00:1f.4
4666 E: ID_PATH_TAG=pci-0000_00_1f_4
4667 E: ID_FOR_SEAT=input-pci-0000_00_1f_4
4668 E: TAGS=:seat:

And, as confirmed with them, in this case, when ID_INPUT_POINTINGSTICK=1 and ID_INPUT_MOUSE=1, the TrackPoint should be a mouse, not a touchpad. (otherwise the touchpad test cases would be run twice when running Checkbox on this device, which doesn't really make sense)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question is, why should a trackpoint be a mouse?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a separate test case for pointingsitck? If that's present then it's okay to have no touchpad?

self.assertEqual(self.count(devices, "CAPTURE"), 1)
self.assertEqual(self.count(devices, "BLUETOOTH"), 1)
self.assertEqual(self.count(devices, "WIRELESS"), 2)
Expand Down Expand Up @@ -1125,6 +1125,10 @@ def test_CRYPTO_FDE_UC20(self):
self.assertEqual(len(devices), 93)
self.assertEqual(self.count(devices, "PARTITION"), 1)

def test_RESISTIVE_TOUCHPAD(self):
devices = self.parse("RESISTIVE_TOUCHPAD")
self.assertEqual(self.count(devices, "TOUCHPAD"), 1)

def test_two_dms_one_with_ubutnu_save(self):
"""
This test checks that udevadm parser properly handles the case
Expand Down
Loading
Loading