Add glmark2 test for hardware rendering in addition to unity_support_test for devices running wayland (BugFix) #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomli380576
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the
glmark2-es2test to determine whether the DUT is using hardware rendering instead ofunity_support_test. It checks the output of glmark2 for a GL_RENDERER string and uses the same logic as unity_support_test to see if it's produced by a software renderer.Requires #1671
Resolved issues
#1630
Debian version of glmark2 returns the correct string on Mali platforms whereas unity_support_test doesn't.
Documentation
The basic idea is to check XDG_SESSION_TYPE, which should be set once graphical.target is reached, and run glmark2-es2 for wayland, unity_support_test for X11. If unset, run glmark2.
Tests
Original unit tests
Real hardware: x86 laptops and the Mali device in #1630