-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): add SDF for iputils-ping #449
feat(24.04): add SDF for iputils-ping #449
Conversation
Diff of dependencies: |
1f08566
to
368abd9
Compare
Fix integration test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a quick comment, similar to #447 (review)
add fundamental operational test
add fundamental operational test
@cjdcordeiro, what sort of functional test do you believe would be appropriate for the I attempted to do something like this for So I'm not sure what exactly would be appropriate for a network type utility such as |
127.0.0.1 should always be available I think. Do you recall what kind of errors you were getting with Redis? |
See https://github.com/canonical/chisel-releases/actions/runs/12213930844/job/34074096427 |
it's hard to be sure that was a networking problem, as it could also have been a Since these last commits are passing with 127.0.0.1 , I suggest we stick to that, and if we see some problems later on, we try to rethink the testing infrastructure, but not the tests themselves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the spread test using 127.0.0.1
will not cause any failure in testing the standalone iputils-ping
binaries. I agree with @cjdcordeiro that we can stick to using 127.0.0.1
in the tests for now.
This looks good to me. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the changes
Proposed changes
feat(24.04): add SDF for iputils-ping
Related issues/PRs
Forward porting
Checklist
Additional Context