Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): add SDF for iputils-ping #449

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

eunufe
Copy link

@eunufe eunufe commented Jan 6, 2025

Proposed changes

feat(24.04): add SDF for iputils-ping

Related issues/PRs

Forward porting

Checklist

Additional Context

Copy link

github-actions bot commented Jan 6, 2025

Diff of dependencies:
None found.


Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a quick comment, similar to #447 (review)

eunufe added 2 commits January 7, 2025 10:13
add fundamental operational test
add fundamental operational test
@norrisjeremy
Copy link

Thanks! Just a quick comment, similar to #447 (review)

@cjdcordeiro, what sort of functional test do you believe would be appropriate for the ping utility that would be guaranteed to be functional when running the spread test suite?

I attempted to do something like this for redis, however the networking setup when Github ran the workflow for this seemed to make it difficult and caused it fail.

So I'm not sure what exactly would be appropriate for a network type utility such as ping, since it networking maybe flaky in whatever environment is used to execute the spread test suite?

@cjdcordeiro
Copy link
Collaborator

Thanks! Just a quick comment, similar to #447 (review)

@cjdcordeiro, what sort of functional test do you believe would be appropriate for the ping utility that would be guaranteed to be functional when running the spread test suite?

I attempted to do something like this for redis, however the networking setup when Github ran the workflow for this seemed to make it difficult and caused it fail.

So I'm not sure what exactly would be appropriate for a network type utility such as ping, since it networking maybe flaky in whatever environment is used to execute the spread test suite?

127.0.0.1 should always be available I think. localhost might not (as shown in https://github.com/canonical/chisel-releases/actions/runs/12654994997/job/35264222549) due to lacking name resolution inside the chroot environment.

Do you recall what kind of errors you were getting with Redis?

@norrisjeremy
Copy link

Thanks! Just a quick comment, similar to #447 (review)

@cjdcordeiro, what sort of functional test do you believe would be appropriate for the ping utility that would be guaranteed to be functional when running the spread test suite?
I attempted to do something like this for redis, however the networking setup when Github ran the workflow for this seemed to make it difficult and caused it fail.
So I'm not sure what exactly would be appropriate for a network type utility such as ping, since it networking maybe flaky in whatever environment is used to execute the spread test suite?

127.0.0.1 should always be available I think. localhost might not (as shown in https://github.com/canonical/chisel-releases/actions/runs/12654994997/job/35264222549) due to lacking name resolution inside the chroot environment.

Do you recall what kind of errors you were getting with Redis?

See https://github.com/canonical/chisel-releases/actions/runs/12213930844/job/34074096427

@cjdcordeiro
Copy link
Collaborator

it's hard to be sure that was a networking problem, as it could also have been a redis-server availability issue.

Since these last commits are passing with 127.0.0.1 , I suggest we stick to that, and if we see some problems later on, we try to rethink the testing infrastructure, but not the tests themselves.

Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the spread test using 127.0.0.1 will not cause any failure in testing the standalone iputils-ping binaries. I agree with @cjdcordeiro that we can stick to using 127.0.0.1 in the tests for now.

This looks good to me. Thanks.

Copy link

@clay-lake clay-lake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution!

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the changes

@cjdcordeiro cjdcordeiro merged commit f6a4080 into canonical:ubuntu-24.04 Jan 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants