Fix availability zones and topology configuration

[VariableDeclared]

Fixes

• https://bugs.launchpad.net/charm-cinder-csi/+bug/2046364
• https://bugs.launchpad.net/charm-cinder-csi/+bug/2059126

[addyess]

Looking VERY nice. thank you so much
Few nits/questions

[addyess]

Really looking great. Would you rebase as well since i fixed the linting issue in main

[VariableDeclared]

thanks again @addyess !

[addyess]

Hopefully my last nits i swear

[VariableDeclared]

thank you again @addyess for your comprehensive review! I really should fix my workpace

[addyess]

I may have sent you down a bum path unintentionally. And for that i'm sorry @VariableDeclared

[addyess]

Oops... i didn't do you well if i suggested this line change. This shouldn't be changed. It was totally incorrect before

Suggested change

	if not (obj.kind == "Deployment" and obj.metadata.name == "csi-cinder-controllerplugin"):
	if not any(
	[
	(obj.kind == "DaemonSet" and obj.metadata.name == "csi-cinder-nodeplugin"),
	(obj.kind == "Deployment" and obj.metadata.name == "csi-cinder-controllerplugin"),
	]
	):

[VariableDeclared]

gosh, my mistake

[addyess]

instead this one only appiles to the controller plugins

Suggested change

	if not any(
	[
	(obj.kind == "Deployment" and obj.metadata.name == "csi-cinder-controllerplugin"),
	]
	):
	if not (obj.kind == "Deployment" and obj.metadata.name == "csi-cinder-controllerplugin"):

[VariableDeclared]

yup!

[VariableDeclared]

thank you again! made those changes

[addyess]

@VariableDeclared

i'm spotting errors in the unit tests:

  File "/home/runner/work/cinder-csi-operator/cinder-csi-operator/tests/unit/test_charm.py", line 162, in test_waits_for_kube_control
    assert storage_messages == {
AssertionError: assert {'Setting secret for Deployment/csi-cinder-controllerplugin', 'Encode secret data for storage.', 'Setting secret for DaemonSet/csi-cinder-nodeplugin', 'Configuring cinder topology awareness=true', 'Creating storage class csi-cinder-default'} == {'Creating storage class csi-cinder-default', 'Setting secret for Deployment/csi-cinder-controllerplugin', 'Setting secret for DaemonSet/csi-cinder-nodeplugin', 'Encode secret data for storage.'}
  
  Extra items in the left set:
  'Configuring cinder topology awareness=true'
  
  Full diff:
    {
  +     'Configuring cinder topology awareness=true',
        'Creating storage class csi-cinder-default',
        'Encode secret data for storage.',
        'Setting secret for DaemonSet/csi-cinder-nodeplugin',
        'Setting secret for Deployment/csi-cinder-controllerplugin',
    }

Looks like we need to add following line 162 of /tests/unit/test_charm.py

'Configuring cinder topology awareness=true'

[addyess]

Hooray! 🍰
LGTM