Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flake8 fixes #4340

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Flake8 fixes #4340

merged 1 commit into from
Aug 14, 2023

Conversation

rjschwei
Copy link
Contributor

Proposed Commit Message

summary: flake8 fixes

Address complaints by newer versions of flake8, these are not picked up by ruff

Additional Context

Test Steps

Checklist:

  • [ x] My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@rjschwei
Flake8 fixes
772e22d 
Address complaints by newer versions of flake8, these are not picked up by ruff
blackboxsw
blackboxsw approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjschwei we can discuss separately ruff vs flake8 and outstanding needs for formatting and linting in different environments in #4339

@blackboxsw blackboxsw merged commit b1f4a27 into canonical:main Aug 14, 2023
25 checks passed
@rjschwei rjschwei deleted the newFlake branch October 9, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackboxsw blackboxsw blackboxsw approved these changes

@cjp256 cjp256 cjp256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjschwei @cjp256 @blackboxsw