Revert allowing pro service warnings #4483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 67bb6aa. Since pycloudlib has been updated to no longer allow a failure of this type, we can be more stringent in what we allow. Additionally, bump pycloudlib version accordingly.
blackboxsw
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
csmith@midtown:~/src/cloud-init$ CLOUD_INIT_OS_IMAGE=jammy CLOUD_INIT_PLATFORM=ec2 tox -e integration-tests tests/integration_tests/modules/test_ubuntu_advantage.py::TestUbuntuAdvantagePro::test_custom_services
integration-tests: commands succeeded
congratulations :)
Tests happy, I'm happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
https://github.com/canonical/pycloudlib/pull/320/files