Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove CPY check from ruff #5281

Merged
merged 1 commit into from
May 10, 2024

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

chore: Remove CPY check from ruff

The check is being ignored on our version of ruff because it was in
preview mode and we don't pass the `--preview` flag.
Additionally, this rule has tons of errors and isn't useful for
our codebase in its current state.

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

The check is being ignored on our version of ruff because it was in
preview mode and we don't pass the `--preview` flag.
Additionally, this rule has tons of errors and isn't useful for
our codebase in its current state.
@TheRealFalcon TheRealFalcon merged commit 63a0fcd into canonical:main May 10, 2024
28 of 29 checks passed
@TheRealFalcon TheRealFalcon deleted the remove-cpy branch May 10, 2024 14:13
holmanb pushed a commit that referenced this pull request Jun 28, 2024
The check is being ignored on our version of ruff because it was in
preview mode and we don't pass the `--preview` flag.
Additionally, this rule has tons of errors and isn't useful for
our codebase in its current state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants