fix(azure): disable use-dns for secondary nics #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danpdraper and @cjp256, I have created this PR superseding #5180. Please review it, thanks. |
aciba90
force-pushed
the
multi_nic_netplan_azure
branch
from
de6b540
to
7955e11
Compare
cjp256
approved these changes
May 22, 2024
danpdraper
reviewed
May 22, 2024
DNS resolution through secondary NICs is not supported on Azure. Disable it. Without this, we see seconds of delay resolving urls in cloud-init logs from Jammy+, see SF ticket. Per cjp256's comment, the first NIC under metadata.imds.network is ensured to be the primary one. We use this to determine primary NICs instead of relying on fragile driver and/or NIC names. Fixes: SF: #00380708 Co-authored-by: Calvin Mwadime <calvin.mwadime@canonical.com>
aciba90
force-pushed
the
multi_nic_netplan_azure
branch
from
7955e11
to
6d28fc9
Compare
danpdraper
approved these changes
May 23, 2024
|
Just wanted to say thanks again @aciba90! Testing looks great so far. |
|
Thank you, @cjp256, for the support and testing! Let us know if anything goes wrong. |
5 tasks
holmanb
pushed a commit
that referenced
this pull request
Jun 28, 2024
DNS resolution through secondary NICs is not supported on Azure. Disable it. Without this, we see seconds of delay resolving urls in cloud-init logs from Jammy+, see SF ticket. Per cjp256's comment, the first NIC under metadata.imds.network is ensured to be the primary one. We use this to determine primary NICs instead of relying on fragile driver and/or NIC names. Fixes: SF: #00380708 Co-authored-by: Calvin Mwadime <calvin.mwadime@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Supersedes #5180, see comments for more context.
Closes:
Test Steps
Checklist
Merge type