Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(autoinstall): Remove incorrect statements, be more direct #5545

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Jul 24, 2024

Commit message

doc(autoinstall): Remove incorrect statements, be more direct

Additional Context

Top level keys are no longer ignored, so drop this incorrect statement.

Tailor this section more directly toward subiquity / autoinstall, since
that is where the frequently asked questions come from.

@github-actions github-actions bot added the documentation This Pull Request changes documentation label Jul 24, 2024
Copy link
Contributor

@aciba90 aciba90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I left a minor nit comment.

doc/rtd/reference/faq.rst Show resolved Hide resolved
``cloud-init``'s cloud-config with additional keys.

If you are an autoinstall user, please direct questions to their IRC channel
(``#ubuntu-server`` on Libera) or Discourse.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include a link to their Discourse?

Copy link
Contributor

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the mentioned comments, LGTM :)

@holmanb holmanb merged commit 779dd6b into canonical:main Jul 25, 2024
24 checks passed
holmanb added a commit to holmanb/cloud-init that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This Pull Request changes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants